From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A59F7280A56 for ; Thu, 30 Jul 2026 03:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785381030; cv=none; b=C44k+WdF11YatjW0YD/IGl3sB6wNJm/0X6IJ9jviCuBT1Nmm8i8ZG11vjXCTcv5vKCyVngFFqyXe0MrEPN4WWaeMvOujs8zu7tkkksN66AkXhPR5D8Za5UHoVEJpiQRnKvnSgpoh+8UAr9K0kcBIAnnvQMjBTeFncJEMGW+ifRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785381030; c=relaxed/simple; bh=88exG9pmM3SMqGni5Yb7adCKozp57ZgOq/ZTuaDDark=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mez5Ydl0oXTgtCIwecBSsnH7C0xQTqQ0ANANa94r+LtJoezDeV5FMz4ewEY3pKJtaihet1/IwKGQYx1bplkAJNmBRBpZ0uVGEsSOxGpJj2KtyQ3OKN15y1a7Zed7xM+sw4Q8Fb0I7yOKjiJmbFkoqzDYTNdtPjJaLgC++yPNPPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=naIbZB4m; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="naIbZB4m" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8485ef63b68so1847973b3a.1 for ; Wed, 29 Jul 2026 20:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785381028; x=1785985828; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=oOgqqXrAi7XNSCeF+yJUxbdmJlZKU68fKb3Gfk4Uqyk=; b=naIbZB4mjX93xHikZaPI+kI/CNE8OkfBj20Q/jAo3vnQTIhjIeHhTvAN3R3TnH1lVk OfMyPusqyDJIYOD/C/cl4lAUvWDerGRD9PROBmLpcEUgsWHeho8JRzjGrlycZPVKnse3 1S1mIHTqdH6sYpPSJX0MctIOLyIXxwS0AUmyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785381028; x=1785985828; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oOgqqXrAi7XNSCeF+yJUxbdmJlZKU68fKb3Gfk4Uqyk=; b=qCgL0mhIufoT9RhMEKuQdqbwsg+DZrWEn+ESKBhHc+ORDVnKA93OUWH1XAgi6mJD5E MB0jwnj7jBDVDtqqFQQRVNIXwFtUJPm8Es+1zyADko2Tcliz1oBQe3KW0iKJgPev/itA RCJek3+DHFF2pBRRwQIOTTPIG0S0V5F5NLfWvcr5IW6NKWQCNheCq1t1IeIwILO5QUZD LzINT2GjSroWW2lpO3YH/PcYr0+a4rZgf2mLjUiuq42blMeMj1aa9yjNfyk4BgeheJ00 wVEEwQ3wp0whyH/XJVIk0QbtsLfaCpUsb0hfBVVLHkOhmy/qjUK5Ec7gQGCui5Q8T9ur e5Zw== X-Forwarded-Encrypted: i=1; AHgh+RqTcoPvlhSmU25kMBvFGa92en99vB+Yeg+aBT70mLANaxT7Lvf6mPBud3xyQHNCfnVH95d65VGCX8ejjXk=@vger.kernel.org X-Gm-Message-State: AOJu0YxY5mJFV5nXE8aU0rpy6VDUf4A85RvwgIUaSz1dxdhPTxJMZaPf ZD+zZF7ppnITBIba2++qFrrAoNPqLE7AoXz1L4yewD9VQHkys07iO2FmuO5obWtbgQ== X-Gm-Gg: AR+sD110P8+nIAdYfH7BZkLuiA/wINfQmrv7KhIXTca9cIwIvKA0zd+c0ntPRRNadM5 ViO++nAooRg38v1jmTIV3xLf6bcfe3odYzLOBViO50GDd47Tq+4zOp7Byu8gxCcpsxn35M6MwJc aPLDqGBGsVpGI+ZcmFg4TRdQWaStwRrpt1hoEAwVIHfQfHHjyFwCCYFIHPi1O+jkCnIvfi408T5 oaZkiVKYM/yIE+xxhZOX6NypqlLQdU+9sbC1VnucI5T1B9tLQPiHqguVMqzZVOUbcFbLr90IIrN 2zuysdWq0CAY8Gfw/RsthAI0TUgYOkevIqzUDJngUSzrw6ZqdMfv4BNCyuRryuH2SZygx1IC3ev 9Q7zCyhGsCEaYD3XCP4oO/t3wS3O9RAkUu2p4LsOrs7L4rEY566abBiqJIQJ/M5pEelWoleDQI5 bzoLI3tILBRy9aOhx5pQ/xmuIkOgYgTOpsu+rCeYasWVrUIHngFEDBkXFDIvrlIp1ecoiLQKut5 d3raniH098L8G1++dnX8xWd4TkHQSdOcpywb4U= X-Received: by 2002:a05:6a00:e13:b0:848:4809:51da with SMTP id d2e1a72fcca58-84ebc3dd06dmr906931b3a.50.1785381027894; Wed, 29 Jul 2026 20:10:27 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:fd2f:da94:c3be:e16c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea0054afesm2240292b3a.17.2026.07.29.20.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 20:10:27 -0700 (PDT) Date: Thu, 30 Jul 2026 12:10:22 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH v3 3/5] zram: add level validation in zstd setup_params Message-ID: References: <20260728092935.31139-1-haoqinhuang7@gmail.com> <20260730025240.17724-1-haoqinhuang7@gmail.com> <20260730025240.17724-4-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730025240.17724-4-haoqinhuang7@gmail.com> On (26/07/30 10:52), Haoqin Huang wrote: [..] > diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c > index 2584f47c9b3c..6febb366f76e 100644 > --- a/drivers/block/zram/backend_zstd.c > +++ b/drivers/block/zram/backend_zstd.c > @@ -60,6 +60,11 @@ static int zstd_setup_params(struct zcomp_params *params) > params->drv_data = zp; > if (params->level == ZCOMP_PARAM_NOT_SET) > params->level = zstd_default_clevel(); > + else if (params->level < -(int)ZSTD_TARGETLENGTH_MAX || I was expecting to see zstd_min_clevel() here. What is this -(int)ZSTD_TARGETLENGTH_MAX? > + params->level > zstd_max_clevel()) { > + pr_err("zstd: invalid compression level %d\n", params->level); > + goto error; > + }