Re: [PATCHv2 bpf-next 11/11] bpf: Clear buf on error in __bpf_get_task_stack

[Jiri Olsa <olsajiri@gmail.com>]

On Wed, Jul 29, 2026 at 09:57:58AM +0000, bot+bpf-ci@kernel.org wrote:
> > bpf: Clear buf on error in __bpf_get_task_stack
> >
> > Both bpf_get_task_stack and bpf_get_task_stack helpers that use
> > __bpf_get_task_stack have buf defined as ARG_PTR_TO_UNINIT_MEM
> > argument, and we should initialize the buf on every return path.
> 
> [ ... ]
> 
> The first sentence names the same helper twice, "Both bpf_get_task_stack
> and bpf_get_task_stack helpers".
> 
> There are two callers of __bpf_get_task_stack() in kernel/bpf/stackmap.c:
> 
>     BPF_CALL_4(bpf_get_task_stack, ...)            /* may_fault = false */
>     BPF_CALL_4(bpf_get_task_stack_sleepable, ...)  /* may_fault = true */
> 
> Should the second name be bpf_get_task_stack_sleepable?
> 
> Both of those helpers do declare .arg2_type = ARG_PTR_TO_UNINIT_MEM, so
> the rest of the sentence looks right, it just reads as "both x and x" at
> the moment.

yep, will fix

jirka

> 
> 
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
> 
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/30437558115