All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Cc: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com,
	matthew.brost@intel.com, anshuman.gupta@intel.com,
	badal.nilawar@intel.com, vinay.belgaumkar@intel.com,
	riana.tauro@intel.com, karthik.poosa@intel.com,
	sk.anirban@intel.com
Subject: Re: [PATCH] drm/xe/ras: Split RAS init into xe_ras_init_early and xe_ras_init
Date: Thu, 30 Jul 2026 10:57:47 +0200	[thread overview]
Message-ID: <amsSC57qtHNAj4gs@black.igk.intel.com> (raw)
In-Reply-To: <20260730065430.902562-2-mallesh.koujalagi@intel.com>

On Thu, Jul 30, 2026 at 12:24:31PM +0530, Mallesh Koujalagi wrote:
> xe_ras_init() was doing two unrelated things: setting up internal
> bookkeeping needed before interrupts start, and querying firmware
> errors that can only be done safely after the device is registered.
> 
> Split it into two functions with clear responsibilities:
> 
> - xe_ras_init_early(): runs early, before interrupts are enabled.
> 
> - xe_ras_init(): runs after the device is registered.

Why not just xe_ras_process_errors() after drm_dev_register() and keep
the rest as is?

With,

Fixes: d9732e498f5f ("drm/xe/xe_ras: Query errors from system controller on probe")

Also, IIUC process_hw_errors() suffers from the same problem after commit
a7df563b45b0 ("drm/xe/xe_hw_error: Handle CSC Firmware reported Hardware
errors"), which we also might want to fix at some point.

Raag

  parent reply	other threads:[~2026-07-30  8:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30  6:54 [PATCH] drm/xe/ras: Split RAS init into xe_ras_init_early and xe_ras_init Mallesh Koujalagi
2026-07-30  6:57 ` Gupta, Anshuman
2026-07-30  7:01 ` ✓ CI.KUnit: success for " Patchwork
2026-07-30  7:36 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-30  8:48 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-30  8:57 ` Raag Jadav [this message]
2026-07-30 11:10   ` [PATCH] " Raag Jadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amsSC57qtHNAj4gs@black.igk.intel.com \
    --to=raag.jadav@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.