All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: yocto-patches@lists.yoctoproject.org
Subject: Re: [yocto-patches] [wic][PATCH v2 0/4] oe/path: three fixes plus unit coverage
Date: Thu, 30 Jul 2026 11:57:10 -0400	[thread overview]
Message-ID: <amt0VjtgxpZX2VkE@localhost.localdomain> (raw)
In-Reply-To: <0db1bbae64602548db4132db0d1397254daf8949.camel@pbarker.dev>

On Thu 2026-07-30 @ 01:04:05 PM, Paul Barker via lists.yoctoproject.org wrote:
> On Thu, 2026-07-30 at 07:55 -0400, Trevor Woerner via
> lists.yoctoproject.org wrote:
> > On Fri 2026-07-24 @ 04:04:55 PM, Paul Barker via lists.yoctoproject.org wrote:
> > > On Fri, 2026-07-24 at 07:50 -0400, Trevor Woerner via
> > > lists.yoctoproject.org wrote:
> > > > This series continues the standalone unit-test work, this time over
> > > > oe/path.py. It follows the same shape the suite settled on: each
> > > > source fix is its own standalone commit, and the green test module
> > > > lands last, so the suite passes at every commit.
> > > 
> > > LGTM, assuming these are direct copies of what was added to OE-core.
> > 
> > Almost. The 3 "fix" patches are identical, but the unit test patch is
> > different because wic uses pytest and oe-core uses unittest. The test
> > coverage and what is tested are the same between them, just expressed
> > differently depending on the test framework.
> 
> Thanks for clarifying. wic doesn't need to be limited to using unittest,
> so this makes sense to me :)
> 
> Reviewed-by: Paul Barker <paul@pbarker.dev>

Excellent! Thank you for your review!
This series has been applied to wic, master branch.


      reply	other threads:[~2026-07-30 15:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 11:50 [wic][PATCH v2 0/4] oe/path: three fixes plus unit coverage Trevor Woerner
2026-07-24 11:50 ` [wic][PATCH v2 1/4] oe/path: fix bare `false` NameError in __realpath's isdir guard Trevor Woerner
2026-07-24 11:50 ` [wic][PATCH v2 2/4] oe/path: don't glob-expand the destination in symlink(force=True) Trevor Woerner
2026-07-24 11:50 ` [wic][PATCH v2 3/4] oe/path: canonicalize('') should return '' rather than the cwd Trevor Woerner
2026-07-24 11:50 ` [wic][PATCH v2 4/4] tests/unit/test_oe_path: cover oe/path's own path logic Trevor Woerner
2026-07-24 15:04 ` [yocto-patches] [wic][PATCH v2 0/4] oe/path: three fixes plus unit coverage Paul Barker
2026-07-30 11:55   ` Trevor Woerner
2026-07-30 12:04     ` Paul Barker
2026-07-30 15:57       ` Trevor Woerner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amt0VjtgxpZX2VkE@localhost.localdomain \
    --to=twoerner@gmail.com \
    --cc=yocto-patches@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.