From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4DCA43DA3C for ; Thu, 30 Jul 2026 14:27:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421630; cv=none; b=I87IAEYneA3Iu7H0PqIP/EZgi5QBFDlXhO7ROBjMS7+eT/Bf5gLDulhWom9eWbGKYBCJ2kre7P5zKapzli/dH0Zoy4fI1PPUpT1nNyAe1J2fSf9aFGHxs8VhBb21kjGwqCKaOgqFSSplCyIq016HeQGJx6eEljPdIvcslMENcP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421630; c=relaxed/simple; bh=CsVyAHTj9KASWm8xPmBrjQBBsW9y/NmxPWYlZm9qQ8k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZYO9i4U9MlSMu2EHUXc/DYGuiQBgPggJn+lPlJ9VSH8AuLtIw3UkDS1vk8W9ti8yN3S5JsCsBexFbK72d9Z8ZQLvjTo75ZmBZzdkLtg1G/7uthynvSp5F0wiwCPuPt4iGxjvDV5sX84bmKejA+6QiuyEtbyKJXU2ERdDa70Vq3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e/7nxGKu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e/7nxGKu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 535DC1F00A3A; Thu, 30 Jul 2026 14:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785421629; bh=CsVyAHTj9KASWm8xPmBrjQBBsW9y/NmxPWYlZm9qQ8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=e/7nxGKuYCKRYoG7zYuAOV0k8zgwH3+x+keQXSDvu3NEfarYOsSm+u+W5fKMZPlr2 ImEqmPTEJHlRbnnJL+BK5ZZ90r4Qwu75B6hga3f3eWfSGb4huaizZBHwaavpbDvxly tvBZQ8nKdamQp/iS9uxs9zk4wPwnaKvEvQkKTOFoQCAoigR9sRKXMHnVwMwof9mLcF DUxyFjzl+teAgXICm9xXcXPGdLRAj2qX1m2c2/mDwVMmYqx2Qtj8FhAoZArkwmYl50 seEtsP2wWTrMPGc7rqiHH5TMN/+4hhyTTIPEnGvHdZjDV5Un2XOwoX6IFN+mZkp2mL ozNN0T5FrNmhw== Date: Thu, 30 Jul 2026 08:27:07 -0600 From: Keith Busch To: Greg Kroah-Hartman Cc: Christoph Hellwig , Hari Mishal , Jens Axboe , Sagi Grimberg , Hannes Reinecke , Kanchan Joshi , Nitesh Shetty , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] nvme: drop WARN_ON_ONCE on write_stream bounds check Message-ID: References: <2026072748-unpopular-onlooker-4a2b@gregkh> <2026072849-uproar-aqua-07c3@gregkh> <20260728051838.GA20593@lst.de> <2026072834-buffoon-entwine-ed16@gregkh> <20260730114123.GB25956@lst.de> <2026073003-primp-granular-c176@gregkh> <20260730133726.GA2983@lst.de> <2026073049-improper-paparazzi-6be7@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026073049-improper-paparazzi-6be7@gregkh> On Thu, Jul 30, 2026 at 04:04:03PM +0200, Greg Kroah-Hartman wrote: > It's only the systems that have panic-on-warn enabled that need to worry > about user-triggered calls to that macro, and those systems know what > they are getting themselves into, including the huge number of CVE fixes > they then need to be responsible for backporting :) This is a bit of a rug pull. We've long held the pattern that WARN is an appropriate macro for conditions that should never happen, but don't leave the system in an unrecoverable or compromised state. For unrecoverable conditions, use BUG. It has been a valuable tool for debugging and bug reporting. If this is the new way, can we get a WARN_NO_PANIC so that we can replace every instance of WARN with it? Then we can delete WARN and lighten the CVE load. I'm not advocating for WARN's in paths triggered by buggy or malicious users, but we don't need panic-on-warn to justify removing those cases either.