From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA85C55162 for ; Thu, 30 Jul 2026 14:28:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4h9s564Kzjz2xnp; Fri, 31 Jul 2026 00:28:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=95.215.58.182 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785421722; cv=none; b=O5Yo4Kku6tcGevGINyM1tC+KZOkfA4DUOpV9gn2AL1TRVBmrdhH7/qMJ3fPxeX/iuQ3yEhP4VPLU1fnhEx01mtgDm2ZgKqs+3yMekI8TRhFgn6tiA6pA/L8/OVpZJ3IM4bgJ4x3f7yay+eqFu5eOEaeDqqfb1TVj+Pvh8fE7YiU1zryDj7kgLDaEHGuhgVvsdsbOwtzOZRsEgw2yhL99IygcsYde+W6R7kd/1gABS1EqHr7jO9E3OvPJjYI6/N22mrbVzCaMhr3B3JQAfy5nVjjmWq5U2pnq5BQKgihShGJ/O3z3yB5kfp8YRzVvuWok2Oc+232yeYkl7uhhfXNJFg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785421722; c=relaxed/relaxed; bh=T3ac2CFXlJ8wxc4DqXVNNL1F/4/fTPWOM+4N0hlAhII=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nCTqXZcrePd5CYc3pUe/+CMK2Gmeho4cYkxFJaIyKH7WTn71zb+RnDF3EaHYS6teNexCs9/l+fP9/FAFToOKRZSFa2AxZyxTp9wHPxhdKUZBpl60mIFaIl0IbopKpH3COLw1DIg499GNJYWTcGtYrmYHUKP3hoMflA7QvtaX+ULvGJp31I/Sxmx0C1R3OVhSuRlzyzqmYCFhSZRPxRxt8x0o7ravskWdanB4DhV9Im3ctfobVzoEqGbJY8lm7Br+R+8PQzaoD+zwdF2Q9PKJtP6efCTUHwYnXoS7e2l4P2txeCyAZtoUdc3XNP7wl695KM/4z94rPULLynm10IUkZg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=aBc6kdGc; dkim-atps=neutral; spf=pass (client-ip=95.215.58.182; helo=out-182.mta1.migadu.com; envelope-from=thorsten.blum@linux.dev; receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=aBc6kdGc; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev (client-ip=95.215.58.182; helo=out-182.mta1.migadu.com; envelope-from=thorsten.blum@linux.dev; receiver=lists.ozlabs.org) Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4h9s530pTcz2xd2 for ; Fri, 31 Jul 2026 00:28:37 +1000 (AEST) Date: Thu, 30 Jul 2026 16:28:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785421697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T3ac2CFXlJ8wxc4DqXVNNL1F/4/fTPWOM+4N0hlAhII=; b=aBc6kdGcrvmf1QuzIJqjJzWr6cBQtAVoQZwfblt82hs7QBtFv9g1ht5WiphIz5IiiJs+Ng fxcG8bNO70eRzMDjTk5DFFwB6yJmRF+dO32tFajrUulkJNltWqtigsYRI0NLcMJC1bBVF8 x0ttg5NeKVL444ftwoAark8BL1FwFuw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Justin Stitt , Kees Cook Cc: stable@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ps3: Fix repository.c build failure Message-ID: References: <20260703165834.137242-2-thorsten.blum@linux.dev> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed, Jul 29, 2026 at 06:56:59PM +0200, Thorsten Blum wrote: > On Fri, Jul 03, 2026 at 06:58:35PM +0200, Thorsten Blum wrote: > > GCC fails to build ps3_defconfig with the following errors: > > > > arch/powerpc/platforms/ps3/repository.c: In function ‘make_first_field.constprop’: > > arch/powerpc/platforms/ps3/repository.c:78:9: error: ‘strnlen’ specified bound 8 exceeds source size 3 [-Werror=stringop-overread] > > 78 | memcpy((char *)&n, text, strnlen(text, sizeof(n))); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > arch/powerpc/platforms/ps3/repository.c: In function ‘make_first_field.constprop’: > > arch/powerpc/platforms/ps3/repository.c:78:9: error: ‘strnlen’ specified bound 8 exceeds source size 4 [-Werror=stringop-overread] > > 78 | memcpy((char *)&n, text, strnlen(text, sizeof(n))); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > The current use of strnlen(text, sizeof(n)) triggers -Wstringop-overread > > when text is a short string literal that is smaller than sizeof(n), such > > as "bi" or "bus". Use strlen(text) instead and clamp the copy length to > > sizeof(n) before memcpy(). > > > > Drop the redundant char * cast while at it. > > > > Fixes: f94a84a09148 ("powerpc/ps3: refactor strncpy usage") > > Cc: stable@vger.kernel.org > > Signed-off-by: Thorsten Blum > > --- > > arch/powerpc/platforms/ps3/repository.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/ps3/repository.c b/arch/powerpc/platforms/ps3/repository.c > > index b8c030eab138..0cc755ac3e7f 100644 > > --- a/arch/powerpc/platforms/ps3/repository.c > > +++ b/arch/powerpc/platforms/ps3/repository.c > > @@ -6,6 +6,8 @@ > > * Copyright 2006 Sony Corp. > > */ > > > > +#include > > + > > #include > > > > #include "platform.h" > > @@ -74,8 +76,9 @@ static void _dump_node(unsigned int lpar_id, u64 n1, u64 n2, u64 n3, u64 n4, > > static u64 make_first_field(const char *text, u64 index) > > { > > u64 n = 0; > > + size_t len = min(strlen(text), sizeof(n)); > > > > - memcpy((char *)&n, text, strnlen(text, sizeof(n))); > > + memcpy(&n, text, len); > > return PS3_VENDOR_ID_NONE + (n >> 32) + index; > > } > > > > Gentle ping. > > Thanks, > Thorsten Interestingly, GCC 14.2.0 and Clang 22.1.8 don't report an error, whereas GCC 16.1.1 does.