From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CAE5436BF8 for ; Thu, 30 Jul 2026 15:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785426892; cv=none; b=bxGELtH3oS5PN94ZEfAHeKLrIHcOqR+8BoRMqooSIImz3MoEw/4ryUlQzY2i6Xk/ts6Sz+HP0AeZH2RbT/boZM5rasQdzKj/Mx7J3ujeEtzF/wCttfKGsae5X+mQsHQFzpP05hGnzwwP1quPJbH/fGlwXt24FRKoDqfHPiRR9TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785426892; c=relaxed/simple; bh=6RUJbJCJmcOgmBVoIfacETmzluT4jCS47ZikeWc4G18=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qF89F37PRPstds1E/W7yrl+TaEqFOVFAU1OwG3ru4wfATluK0nJvQ6SvXxk3iRFEo9uGDB0h7p3QNNTiaisHD/EV6L7bU95ojJ3Ry7cLp3Ql+EuLgEgr74A0R3LdiN94SMmeRTTsD5J3k+UDL3rHkx1f5ATNadUW5W7QhBpGkc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=S1qxlM8b; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="S1qxlM8b" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38e58034d05so21425a91.2 for ; Thu, 30 Jul 2026 08:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1785426890; x=1786031690; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ffWa1sUD0fV7EQhpv7D4SRQ+QnX1CHB/1+CmFyAsMhI=; b=S1qxlM8badubcVu+2zpnNR9vP5APe33QEemGuVqcmIIVsTyOWeXQNIrkFVGB1OUPgw 8AwGXhCPXL1jxOY7i5dwV77y7TJMWn9XBuHUMPpSg/oHMqJCaBc5tPSbAbBR1fKoTc9p nAqIn+NL5WfZ1rUxYRn0WtLR4j2m+jgQrTYsSUL04xxxihMe5PWSjvWnSpfoovhtfxpx 9bw/mL2y6DsR33MiffSsQtcywRCdlu7LpbuC0hQ739TFTpg/LespTWQiLtrJugHSlHqY T/ogjw72GZvhT3rKpRet8SQp4zgh5ZC1eYkH3Y70S0ruCTy8/qysIDYRNxp7MGRvLQfd 17PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785426890; x=1786031690; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ffWa1sUD0fV7EQhpv7D4SRQ+QnX1CHB/1+CmFyAsMhI=; b=c7spi26XwOSjHDvShtsM0g85Q/OgsrSgDU1tn8ftE4jt1N31J6apbcNV3IeFfS7UF7 ED9WVV9cXT81/9MnZeJY1CT9Wsoz3Xcw+cd2NKFiyi9O7x4+a2sAJOV200At7UPV8Nte SXDnA6Bi4BCucH3g7uDM9mYzPRcQLSwXHv7+iBxlK8oaps+GlDpDAPiwBu2Z5NkocYXx JUDGEj89oOHfqHlu4K2FMfzrFN4gyKFonjV2gDly9hDpNih5+wjccYT52YAHW7OIMUoE guQOo6uuOiNRJ54YZraPQ/ZpWOO0lOHzYf49Lw3dePrYDKrm4q/g/4ZaZQi15zICwufE vGyg== X-Forwarded-Encrypted: i=1; AHgh+RqQiZSPwjm29jrB2JRwG3fraaTipFrt51C/SVaMy4qX4K8bDN+757v3mHZqWqR+kic9TsFGGJ9nG9r84z0=@vger.kernel.org X-Gm-Message-State: AOJu0YxdzWsM81+ilrgVaIWUyUG+b+cHvaRSx9rspBcCSLOZz8OIv0eo UrttImdQolgfpxfVHACaOkxScT2uRnUWKGbeW7TYhnEvIaEdDLHNFz6ls1hNK5LrEg0= X-Gm-Gg: AR+sD11CbXKWveiu2owGE7TrN2TNW3GnRKPhT8bokIwpOCiPIWlV43pIYseTcDiqYNZ eBmn9UB8F+Vb2DhjGhek+SFvCGklrS7H3t9xS4jfU8Uu9cr9UwjyUmRZdP/oI7k7iZ7EPH8ZTrx hRnjjZXKbXaQtnnvm1z0Cr5ZxomUPGml5IdH4k125IFLOhfu09D4Km7BMoGsH98BRttOqvK88uO X9Yox7jkp+UdhsJGrZ3dgkg5Ikhk6n3MQX+J4LmwsbUmyoAtHW9ecR+SQma7PUtg4Bu6C8T9AEz K+WwwC4xe+j/lGr6Omx2LcpYLz+l30imLtjCPevjNB4mmAz/KepuXRRwtx/MM/XmT4sgQc81Wt6 5BAw9Y2s3PuF6P7lC/sOgg9y5i5gKZb/FDfPHRUFWbeOS4r60rAU0IHeRMJ4DuVeGpj/447ku2B /GKgITggw54HdBRwTHrpJj8Iui2guG+jPc7SvrUuA0/A== X-Received: by 2002:a17:90b:3b86:b0:381:bc4c:da56 with SMTP id 98e67ed59e1d1-38f9bde74d1mr2714794a91.19.1785426889854; Thu, 30 Jul 2026 08:54:49 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:43::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b99bda7sm1282895a91.12.2026.07.30.08.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 08:54:49 -0700 (PDT) Date: Thu, 30 Jul 2026 08:54:48 -0700 From: Joe Damato To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Konstantin Taranov , Simon Horman , Erni Sri Satya Vennela , Dipayaan Roy , Aditya Garg , Breno Leitao , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, paulros@microsoft.com Subject: Re: [PATCH net-next] net: mana: Extend RX CQE coalescing up to 8 packets Message-ID: Mail-Followup-To: Joe Damato , Haiyang Zhang , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Konstantin Taranov , Simon Horman , Erni Sri Satya Vennela , Dipayaan Roy , Aditya Garg , Breno Leitao , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, paulros@microsoft.com References: <20260729225235.3573786-1-haiyangz@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729225235.3573786-1-haiyangz@linux.microsoft.com> On Wed, Jul 29, 2026 at 03:52:22PM -0700, Haiyang Zhang wrote: > From: Haiyang Zhang > > To support up to 8 packets per CQE, put two packet lengths and > hash values into one PPI entry by using the reserved fields. > Update ethtool handlers to set this feature. > Update per queue stat to show the coalesced CQE counters. > This feature is supported on NIC hardware showing the relevant > PF flag. > > Signed-off-by: Haiyang Zhang > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 137 ++++++++++++------ > .../ethernet/microsoft/mana/mana_ethtool.c | 30 +++- > include/net/mana/gdma.h | 4 + > include/net/mana/mana.h | 43 ++++-- > 4 files changed, 150 insertions(+), 64 deletions(-) > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index a8c329bdbacf..720d22e6aea9 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -1241,6 +1241,9 @@ int mana_gd_query_device_cfg(struct gdma_context *gc, u32 proto_major_ver, [...] > > +static void mana_process_one_rx_pkt(struct device *dev, struct mana_rxq *rxq, > + struct mana_rxcomp_oob *oob, > + u32 pktlen, u32 pkt_hash) > +{ > + struct mana_recv_buf_oob *rxbuf_oob; > + struct net_device *ndev = rxq->ndev; > + void *old_buf = NULL; > + bool old_fp; > + > + rxbuf_oob = &rxq->rx_oobs[rxq->buf_index]; > + WARN_ON_ONCE(rxbuf_oob->wqe_inf.wqe_size_in_bu != 1); > + > + if (unlikely(pktlen > rxq->datasize)) { > + /* Increase it even if mana_rx_skb() isn't called. */ > + rxq->rx_cq.work_done++; > + > + ++ndev->stats.rx_dropped; It looks like this code was moved from mana_process_rx_cqe, so this is prob out of scope, but I saw this and was wondering if maybe rx_length_errors is more appropriate? from if_link.h: * @rx_length_errors: Number of packets dropped due to invalid length. * Part of aggregate "frame" errors in `/proc/net/dev`.