From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Donald Hunter" <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Vivek Kasireddy" <vivek.kasireddy@intel.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Shuah Khan" <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, linux-kselftest@vger.kernel.org,
sdf@fomichev.me, razor@blackwall.org, daniel@iogearbox.net,
almasrymina@google.com, matttbe@kernel.org, skhawaja@google.com,
dw@davidwei.uk, "Joe Damato" <joe@dama.to>,
"Bobby Eshleman" <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next v6 3/3] selftests/net: devmem.py: add check_rx_large_niov
Date: Thu, 30 Jul 2026 14:39:37 -0700 [thread overview]
Message-ID: <amvEJVio9XtCn+YT@devvm29614.prn0.facebook.com> (raw)
In-Reply-To: <20260729191649.55ab7942@kernel.org>
On Wed, Jul 29, 2026 at 07:16:49PM -0700, Jakub Kicinski wrote:
> On Fri, 24 Jul 2026 14:21:17 -0700 Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> >
> > Add a new devmem test case for binding the dmabuf with rx-page-size=16K.
> > The test sweeps RX payload sizes straddling the niov boundary to cover
> > the sub-niov, exact-niov, and multi-niov RX paths.
> >
> > Silence pylint invalid-name (`with open() as f`) and too-many-arguments
> > (ncdevmem_rx grew to 6 args) at file scope.
> >
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
> > Acked-by: Stanislav Fomichev <sdf@fomichev.me>
>
> Hm, odd. In NIPA we're getting:
>
> TAP version 13
> 1..1
> # timeout set to 0
> # selftests: drivers/net/hw: devmem.py
> # TAP version 13
> # 1..5
> # ok 1 devmem.check_rx # SKIP marked as disruptive
> # ok 2 devmem.check_tx # SKIP marked as disruptive
> # ok 3 devmem.check_tx_chunks # SKIP marked as disruptive
> # ok 4 devmem.check_rx_hds # SKIP Test requires devmem support
> # ok 5 devmem.check_rx_large_niov # SKIP Test requires devmem support
> # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:5 error:0
> ok 1 selftests: drivers/net/hw: devmem.py
> # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> https://netdev.bots.linux.dev/logs/hwksft/BCM57508/results/755681/config
> driver: bnxt
> fw: 237.1.148.0
>
> Any idea?
Poking around, it looks like 231.1.167.0 and above should support
everything, so fw should be okay AFAICT.
Looks like the config is missing CONFIG_NET_DEVMEM and CONFIG_UDMABUF?
Sorry, took me a while... was certain it was a bug in my code.
Not the failure here, but wondering if this was on ARM led to seeing
that 16K hardcoded rx_page_size in run_rx_large_niov() may fail on ARM
with 64K pages because it will fail the IS_ALIGN(16K, 64K) check...
Best,
Bobby
next prev parent reply other threads:[~2026-07-30 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 21:21 [PATCH net-next v6 0/3] net: devmem: allow rx-buf-size > PAGE_SIZE per binding Bobby Eshleman
2026-07-24 21:21 ` [PATCH net-next v6 1/3] net: devmem: allow rx-page-size > PAGE_SIZE per dmabuf binding Bobby Eshleman
2026-07-27 8:59 ` Nikolay Aleksandrov
2026-07-30 2:05 ` Jakub Kicinski
2026-07-24 21:21 ` [PATCH net-next v6 2/3] selftests/net: ncdevmem: add -b option to set rx-page-size on bind Bobby Eshleman
2026-07-27 9:03 ` Nikolay Aleksandrov
2026-07-24 21:21 ` [PATCH net-next v6 3/3] selftests/net: devmem.py: add check_rx_large_niov Bobby Eshleman
2026-07-27 9:14 ` Nikolay Aleksandrov
2026-07-30 2:16 ` Jakub Kicinski
2026-07-30 21:39 ` Bobby Eshleman [this message]
2026-07-30 22:14 ` Jakub Kicinski
2026-07-31 0:17 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amvEJVio9XtCn+YT@devvm29614.prn0.facebook.com \
--to=bobbyeshleman@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=christian.koenig@amd.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=kraxel@redhat.com \
--cc=kuba@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=sumit.semwal@linaro.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.