From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: pali@kernel.org, Hongyan Xu <getshell@seu.edu.cn>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
jianhao.xu@seu.edu.cn
Subject: Re: [PATCH] power: supply: isp1704_charger: cancel work on remove
Date: Fri, 31 Jul 2026 01:41:17 +0200 [thread overview]
Message-ID: <amvgh9Z8_HKXEPT1@venus> (raw)
In-Reply-To: <178544907138.238864.16061378690960655968.b4-ty@b4>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
Hi,
On Fri, Jul 31, 2026 at 12:04:31AM +0200, Sebastian Reichel wrote:
> On Tue, 28 Jul 2026 20:33:39 +0800, Hongyan Xu wrote:
> > The USB notifier and initial VBUS detection can schedule isp->work. The
> > remove path unregisters the notifier and power supply, but does not wait
> > for queued or running work before tearing down the power supply state.
> >
> > Cancel the work after unregistering the notifier. Do this before
> > unregistering the power supply.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] power: supply: isp1704_charger: cancel work on remove
> commit: 60c5b8a9ef4dbc5d69bbc1a960fe55826cb3b643
I've added a Fixes tag while applying. But considering nobody cared
in the last 15 years (bug was in this driver since it exists), it
goes the normal route through the next merge window.
Greetings,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-07-30 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 12:33 [PATCH] power: supply: isp1704_charger: cancel work on remove Hongyan Xu
2026-07-30 22:04 ` Sebastian Reichel
2026-07-30 23:41 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amvgh9Z8_HKXEPT1@venus \
--to=sebastian.reichel@collabora.com \
--cc=getshell@seu.edu.cn \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.