All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Ben Horgan <ben.horgan@arm.com>
Cc: Geethasowjanya Akula <gakula@marvell.com>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"james.morse@arm.com" <james.morse@arm.com>,
	Sunil Kovvuri Goutham <sgoutham@marvell.com>,
	Tanmay Jagdale <tanmay@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH v4 1/3] perf: marvell: Add MPAM partid filtering to CN10K TAD PMU
Date: Fri, 31 Jul 2026 16:27:50 +0100	[thread overview]
Message-ID: <amy-9oBsRnQd_Qtr@google.com> (raw)
In-Reply-To: <44cd4364-37ac-4a54-a7b2-256fbad10446@arm.com>

On Fri, Jun 26, 2026 at 09:57:44AM +0100, Ben Horgan wrote:
> >> Where is the user expected to get the PARTID from? The MPAM driver
> >> considers the PARTID as an internal only value.
> >> …
> >> Perhaps some helpers along the lines of:
> >> int resctrl_mount_generation(void)
> >> …
> > Thank you for the detailed feedback — the concern you raise is valid, particularly when 
> > viewed from the perspective of resctrl-managed deployments.
> > 
> > However, to clarify the intent of this patch: the exposure of partid in the TAD PMU is deliberately
> > a low-level, hardware-facing interface, and is not intended to integrate with or mirror the
> > abstractions provided by resctrl. It is mainly meant for platform bring-up and low-level
> > performance/debug users, who already have explicit knowledge of the MPAM configuration,
> > typically provisioned by firmware or other privileged software layers (e.g. EL3/EL2).
> > In such environments, PARTIDs are known out-of-band, so the expectation is that the
> > user supplying partid is already aware of the MPAM IDs programmed on the system.
> 
> When this was proposed before, [1], there was feedback asking to
> document how to get the PARTID.

Yes, please can you update the documentation to cover this? I'm not
necessarily asking for a programmatic way to do it, but even something
like a reference to a document or a firmware table would be useful for
people trying to use the driver to profile their workload. Otherwise,
it's just an opaque id :/

There are also some comments from Sashiko to consider:

https://sashiko.dev/#/patchset/20260618153610.13649-1-gakula@marvell.com?part=1

Thanks,

Will

  reply	other threads:[~2026-07-31 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 15:36 [PATCH v4 0/3] perf: marvell: LLC-TAD PMU MPAM filtering support Geetha sowjanya
2026-06-18 15:36 ` [PATCH v4 1/3] perf: marvell: Add MPAM partid filtering to CN10K TAD PMU Geetha sowjanya
2026-06-18 15:50   ` sashiko-bot
2026-06-25 13:53   ` Ben Horgan
2026-06-26  6:21     ` [EXTERNAL] " Geethasowjanya Akula
2026-06-26  8:57       ` Ben Horgan
2026-07-31 15:27         ` Will Deacon [this message]
2026-06-18 15:36 ` [PATCH v4 2/3] perf: marvell: Add CN20K LLC-TAD PMU support Geetha sowjanya
2026-06-18 15:36 ` [PATCH v4 3/3] dt-bindings: perf: marvell: add CN20K TAD " Geetha sowjanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amy-9oBsRnQd_Qtr@google.com \
    --to=will@kernel.org \
    --cc=ben.horgan@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gakula@marvell.com \
    --cc=james.morse@arm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sgoutham@marvell.com \
    --cc=tanmay@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.