From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4243F432E66 for ; Fri, 31 Jul 2026 14:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785509965; cv=none; b=L/+eOWuzYad/eF5v4sZ64dP/tXJsvzygaRNm9oU5J9o1FvlVarnnNWG2inO2QCwoEzH5vN1J//o/ck66LMNeBBXm7K49ghjSWAmJbAmPm2aWSRhUmxwPwdvYBxMPeMPKPtIhjJa/jDKE8sly7/3RN03N9ml49SUhK5+i07MVgno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785509965; c=relaxed/simple; bh=stRXzenw3Z/xvLD9O77Il60Pnz6mkvyxTAqPw6y1Mdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ltnkUPvgp23y8SetZOV3WKqoeZduWP63cKDhwknCpnX8I6xMK/c+AXJE3CGIxDNgqnGk1lftX0Rgr/2q8rb8EizQs7r1wMiuJbPHsPGx2/HUEWWxl1YjE3BmHUcLUJ1sYkyODbOs7wcJhbE4fmdExa+VFCj1f/IbxQEqUFsqzrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IF3gSZRk; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IF3gSZRk" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c1f758014b8so102475066b.3 for ; Fri, 31 Jul 2026 07:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785509962; x=1786114762; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vb/M1vS07d61qOG/LSX+wmZe1GvzeRqQzFPF7ylBtqg=; b=IF3gSZRk0KjZXYjOdAq8mRfVhmOuKbnyPCd3hdw8ja1HaX9ukHYCELR2srTtU/Hi+C XpzUKKWvHx7xusuvChSSQiMRgCaTMSYUIZXOFJqtl8pWtHnR8u4Oa9t+V63nrgoVYxBq l90bGcAnbigjp5R3PZXvH4c2HZCe5Jy+6DVKL8NacVk0vIyXIZ0dsM+zqowd9cwjk/Na lAIT2VcB9aYOXoTBTPsG6Petix5Gg5uuct4cK4/M3qK1N9BdV+aH0A8MVnAN7SP3rqQV yMQGrgtnksm80tsZ2rl63yLFCTCX0TGAWo1BN6wzeqIVP2WufenPtHScSsbHPuTXev9d pkoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785509962; x=1786114762; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vb/M1vS07d61qOG/LSX+wmZe1GvzeRqQzFPF7ylBtqg=; b=WkIf8Hb9dU5M3neiN0fSMIK04tca6z7jTya1wO0F4SnrEoLWLuZEBKCwlnzcFamr0R mA4UsNSxAIOQMvGMOsZyRfvW+TTk7qznfULB6BpNQ0j4XsZfqGlfkJRnoJ4L8A0aeULy 1KqK5lAap/+yosnSqZNR6oojlK5vL9WtdnXNSv6yDAf0w7Z1X/Y04TqAqig4SCAS2VGc 5kgWwNHdAd6ucU3Nri9ezbmBGnO6NWftGSFPmhtZk96EhY0l4LcBJ0Cy8QDxGTnukRcU ExpW+Pa5YLUD0ObbuFZP0EY2BraekfV+eK69BF6pRUQDFL+HoH59g4k7RtSR1A95cBhH XkJA== X-Forwarded-Encrypted: i=1; AHgh+RrsrKGEgWmXgWumkt89oGUFardbyK26DchD6ZYZBvqKczWqkvPiuUHoZJslEejbLhttar8=@lists.linux.dev X-Gm-Message-State: AOJu0YxyeVmkqV7TX4CVu8Rxa1xB1ND0kRmKj7m7t143KFguAfOlp188 scNLfqVEwz7Q2mGfZckMMXGOLwMf3lYetGY+Y+Z5X1A+kBZ78bMl1E9K84BsOQLX X-Gm-Gg: AR+sD11Ve+XaTrSO5f33bfgaD83oFnk5rpCL0iooNWCfP+lJc3dajr0xRUt8pcsF6Om RaPkoaAD88CmS4lF5fx3TWArLNXUMRPZe6nmTPuO14bWt8LJ69UHH42RJLiW+cckvntKrvgdbj/ Pfone0oSnMxFjhrxXMFRhTs5Ua+UZWW9ksPCnGsEduwhQSdI27jh7O82+d+RiNMRlWr//YKgJf/ 2H4D9OKydrt7ocMm3wIBChYYDEbxWEjsxrIBVJT0eddpyhKcWSh88Tj0iuLDuXSMmgz8vD8iEP7 NaOWf3PhS5TMrvMeUbo1J0bjcrmmQICyLgwToqR7YMjdDNQXSRCs/T/CgNB7P7DNsMYNVjEJLvl u1J+7LRCCm0+NHlhv1uq0WjtEmHexYCprJdCsFdr3w/aELieFkPAFiofWKRsEa7iEGieoOGP572 CuI8A72N/wlJSMkdtOMzqZZpkC4hNu3ut1DR+FDITnhhYP+Quv5wNOz257TsALnvSa2IAZypw8N zSDLRgoHDXWyjpzFvDoURtGB5kJ+3/2iRN5az2gG0DgWf9U0vRFL6oSCcNw6MzrT2HcPZp+iZKu ICIhm9UN0MsztaA06VExAgc+4PDSyt1sXoNdeV0Q0IFL78x+YtPPAfSmAy8zUU/qmX+fRo+zaue iqL1wsRc= X-Received: by 2002:a17:907:97cd:b0:c15:fd85:c5f7 with SMTP id a640c23a62f3a-c1fd1e0fecbmr152256266b.4.1785509962165; Fri, 31 Jul 2026 07:59:22 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a8d0-bc01-6d31-3d12-3a11-d2d0.310.pool.telefonica.de. [2a02:3100:a8d0:bc01:6d31:3d12:3a11:d2d0]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd4537755sm182902566b.54.2026.07.31.07.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 07:59:21 -0700 (PDT) Date: Fri, 31 Jul 2026 16:59:19 +0200 From: Karl Mehltretter To: sashiko-reviews@lists.linux.dev Cc: Frank.Li@kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2 4/4] serial: imx: serialize imx_uart_ports[] lifetime Message-ID: References: <20260719221014.44354-1-kmehltretter@gmail.com> <20260719221014.44354-5-kmehltretter@gmail.com> <20260719222501.CB4CB1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260719222501.CB4CB1F000E9@smtp.kernel.org> On Sun, Jul 19, 2026 at 10:25:00PM +0100, sashiko-bot@kernel.org wrote: > [Severity: High] > If a duplicate UART alias is probed, such as from a misconfigured device > tree, does this unconditionally overwrite an already active port's entry > in imx_uart_ports? > > When uart_add_one_port() subsequently fails for the duplicate, this error > path sets the entry to NULL. The original port remains active, but will > console callbacks that rely on imx_uart_ports[] encounter a NULL pointer > dereference and crash the system? > The existing code already overwrites the active slot. If uart_add_one_port() fails, this leaves the slot pointing to the freed duplicate port. This patch changes that failure mode to a NULL pointer. I'll reject an occupied slot in v3. Thanks, Karl