From: Andi Shyti <andi.shyti@kernel.org>
To: Hardik Prakash <hardikprakash.official@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
wsa@kernel.org, andriy.shevchenko@intel.com,
mario.limonciello@amd.com, brgl@bgdev.pl,
basavaraj.natikar@amd.com, linusw@kernel.org, nathan@kernel.org,
chaitanya.kumar.borah@intel.com, linux@leemhuis.info,
regressions@leemhuis.info, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "i2c: designware: defer probe if child GpioInt controllers are not bound"
Date: Fri, 14 Aug 2026 23:19:51 +0200 [thread overview]
Message-ID: <an-GZpgfiPJj2JsV@zenone.zhora.eu> (raw)
In-Reply-To: <20260814100719.9548-1-hardikprakash.official@gmail.com>
Hi Hardik,
On Fri, Aug 14, 2026 at 03:37:19PM +0530, Hardik Prakash wrote:
> This reverts commit 0a4bb2abc3e56d7be6e69b050c88ba52c87e22bf.
>
> The reverted commit causes a regression on ThinkPad T14s Gen 4 (AMD):
> the touchpad's I2C controller fails with lost arbitration errors,
> because it delays i2c-designware's probe by roughly 500ms, which
> shifts the touchpad's first HID descriptor fetch into a window where
> the platform's embedded controller is still acting as a secondary I2C
> bus master. Debug tracing confirms the GpioInt dependency check itself
> behaves correctly (it defers appropriately and confirms the GPIO
> controller is bound); the arbitration failure happens roughly a
> second after the check passes, when i2c_hid_acpi's own probe attempts
> its first transaction.
>
> The original fix is still needed for the Lenovo Yoga 7 14AGP11
> touchscreen race the commit addressed, but a corrected version will
> be resubmitted once the EC bus-mastering interaction is understood
> and handled properly, rather than reintroducing a different
> regression on more widely-used ThinkPad hardware in the meantime.
>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes: https://lore.kernel.org/all/b4a4eadb-282f-464c-843a-19d415a34d0c@leemhuis.info/
> Signed-off-by: Hardik Prakash <hardikprakash.official@gmail.com>
merged to i2c/i2c-2.
Thanks,
Andi
next prev parent reply other threads:[~2026-08-14 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 10:07 [PATCH] Revert "i2c: designware: defer probe if child GpioInt controllers are not bound" Hardik Prakash
2026-08-14 10:49 ` Thorsten Leemhuis
2026-08-14 14:55 ` Mario Limonciello
2026-08-14 21:19 ` Andi Shyti [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-10 8:37 Hardik Prakash
2026-06-10 10:47 ` Andy Shevchenko
2026-06-10 11:27 ` Borah, Chaitanya Kumar
2026-06-10 16:59 ` Nathan Chancellor
2026-06-14 21:56 ` Andi Shyti
2026-06-15 10:11 ` Andy Shevchenko
2026-06-15 11:07 ` Andi Shyti
2026-06-15 11:11 ` Wolfram Sang
2026-06-15 12:23 ` Linus Walleij
2026-06-15 12:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an-GZpgfiPJj2JsV@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=basavaraj.natikar@amd.com \
--cc=brgl@bgdev.pl \
--cc=chaitanya.kumar.borah@intel.com \
--cc=hardikprakash.official@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mario.limonciello@amd.com \
--cc=nathan@kernel.org \
--cc=regressions@leemhuis.info \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.