All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tsz Shan Chan <tsz.chan.dev@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Tsz Shan Chan" <tchan@jacques.com.au>
Subject: Re: [PATCH 1/2] iio: light: vcnl4000: use correct channel array size
Date: Thu, 13 Aug 2026 10:22:27 +1000	[thread overview]
Message-ID: <an0Mx5C2MMW2pvUi@fedora-1> (raw)
In-Reply-To: <20260812043914.4181b413@jic23-huawei>

On Wed, Aug 12, 2026 at 04:39:14AM +0100, Jonathan Cameron wrote:
> On Tue, 11 Aug 2026 12:53:22 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> 
> > On Tue, Aug 11, 2026 at 05:07:24PM +1000, Tsz Shan Chan wrote:
> > > Use ARRAY_SIZE(vcnl4040_channels) for num_channels to match .channels.  
> > 
> > I was under impression that I have seen this patch a few months ago.
> > In any case sounds like a fix and hence needs a Fixes tag.
> > 
> They are both the same size == 2 I think.
> 
> So whilst nice to fix this I don't see it as needing a fixes tag
> as such.  It would be helpful if the patch description called
> out that the ARRAY_SIZE() of the wrong array happens to match the
> one it should be.
> 
> Jonathan
> 
> 

Thanks. Will update the commit message and send a v2.


  reply	other threads:[~2026-08-13  0:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  7:07 [PATCH 0/2] iio: light: vcnl4000: shared IRQ support Tsz Shan Chan
2026-08-11  7:07 ` [PATCH 1/2] iio: light: vcnl4000: use correct channel array size Tsz Shan Chan
2026-08-11  9:53   ` Andy Shevchenko
2026-08-12  3:39     ` Jonathan Cameron
2026-08-13  0:22       ` Tsz Shan Chan [this message]
2026-08-11  7:07 ` [PATCH 2/2] iio: light: vcnl4000: add shared IRQ support Tsz Shan Chan
2026-08-11  9:49   ` Andy Shevchenko
2026-08-12  3:50     ` Jonathan Cameron
2026-08-13  2:37       ` Tsz Shan Chan
2026-08-13  8:30         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an0Mx5C2MMW2pvUi@fedora-1 \
    --to=tsz.chan.dev@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=tchan@jacques.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.