From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: yaolu@kylinos.cn
Cc: mstrozek@opensource.cirrus.com, perex@perex.cz, tiwai@suse.com,
broonie@kernel.org, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH] ASoC: SDCA: Add stub for sdca_fdl_free_state()
Date: Thu, 13 Aug 2026 09:35:17 +0100 [thread overview]
Message-ID: <an2BxXwxgAZtj0jb@opensource.cirrus.com> (raw)
In-Reply-To: <20260813012636.29735-1-yaolu@kylinos.cn>
On Thu, Aug 13, 2026 at 09:26:36AM +0800, yaolu@kylinos.cn wrote:
> From: Lu Yao <yaolu@kylinos.cn>
>
> Commit 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ
> cleanup") added a call to sdca_fdl_free_state() in sdca_interrupts.c,
> but only declared it in the CONFIG_SND_SOC_SDCA_FDL enabled section of
> sdca_fdl.h. Building SDCA IRQ support without FDL support therefore
> fails with:
>
> sound/soc/sdca/sdca_interrupts.c:471:56: error: 'sdca_fdl_free_state' undeclared (first use in this function); did you mean 'sdca_jack_free_state'?
>
> Fixes: 0880082c27b6 ("ASoC: SDCA: Remove devm from primary IRQ cleanup")
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> ---
This was already fixed here:
https://lore.kernel.org/linux-sound/20260730130602.3747053-1-ckeepax@opensource.cirrus.com/T/#u
Thanks,
Charles
prev parent reply other threads:[~2026-08-13 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 1:26 [PATCH] ASoC: SDCA: Add stub for sdca_fdl_free_state() yaolu
2026-08-13 8:35 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an2BxXwxgAZtj0jb@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=kernel-bot@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yaolu@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.