From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Archit Anant <architanant5@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org,
nuno.sa@analog.com, u.kleine-koenig@baylibre.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/8] iio: adc: ti-ads1015: convert to fully managed resources
Date: Thu, 13 Aug 2026 11:58:26 +0300 [thread overview]
Message-ID: <an2HMjolkHE_l19C@ashevche-desk.local> (raw)
In-Reply-To: <20260812164433.23011-7-architanant5@gmail.com>
On Wed, Aug 12, 2026 at 10:14:31PM +0530, Archit Anant wrote:
> Refactor the driver to use devm_ allocations and power
> management, allowing for the complete removal of the
> ads1015_remove()
...
> - ret = iio_device_register(indio_dev);
> - if (ret < 0) {
> + ret = devm_pm_runtime_set_active_enabled(dev);
> + if (ret)
There are more places with unneeded ' < 0' comparisons, can you add an
intermediate patch to drop those? With that being done, this, in particular,
will have less churn.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-13 8:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 16:44 [PATCH v3 0/8] iio: adc: ti-ads1015: modernize resource management Archit Anant
2026-08-12 16:44 ` [PATCH v3 1/8] iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS() Archit Anant
2026-08-12 16:44 ` [PATCH v3 2/8] iio: adc: ti-ads1015: fix PM leak on probe failure Archit Anant
2026-08-13 8:51 ` Andy Shevchenko
2026-08-22 0:38 ` Jonathan Cameron
2026-08-24 4:54 ` Archit Anant
2026-08-12 16:44 ` [PATCH v3 3/8] iio: adc: ti-ads1015: sort headers alphabetically Archit Anant
2026-08-12 16:44 ` [PATCH v3 4/8] iio: adc: ti-ads1015: use local device pointer in probe Archit Anant
2026-08-12 16:44 ` [PATCH v3 5/8] iio: adc: ti-ads1015: use dev_err_probe() for error handling Archit Anant
2026-08-13 8:55 ` Andy Shevchenko
2026-08-12 16:44 ` [PATCH v3 6/8] iio: adc: ti-ads1015: convert to fully managed resources Archit Anant
2026-08-13 8:58 ` Andy Shevchenko [this message]
2026-08-12 16:44 ` [PATCH v3 7/8] iio: adc: ti-ads1015: replace custom shift macros with FIELD_PREP/GET Archit Anant
2026-08-13 9:02 ` Andy Shevchenko
2026-08-12 16:44 ` [PATCH v3 8/8] iio: adc: ti-ads1015: inline ads1015_set_conv_mode() Archit Anant
2026-08-13 9:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an2HMjolkHE_l19C@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.