From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ming Qing <a0yami@mailbox.org>
Cc: Harald Welte <laforge@gnumonks.org>,
horms@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] gtp: serialize PDP context updates
Date: Thu, 13 Aug 2026 19:39:23 +0200 [thread overview]
Message-ID: <an4BS0kOJaS1BlXC@chamomile> (raw)
In-Reply-To: <2125081283.36735.1786638719082@app.mailbox.org>
On Fri, Aug 14, 2026 at 12:31:59AM +0800, Ming Qing wrote:
>
> > 在 2026/08/11 17:20 CST Pablo Neira Ayuso <pablo@netfilter.org> 写道:
> > This can go away too, for gtp_genl_del_pdp(), the mutex replaces this
> > incorrect rcu read size lock.
> >
> > Thanks.
> >
> > > + mutex_unlock(>p_pdp_lock);
> > > return err;
> > > }
> > >
> > > --
> > > 2.53.0
> > >
>
> gtp_find_pdp() calls gtp_find_dev(), which uses
> dev_get_by_index_rcu(). Should I keep a narrow RCU read-side section
> around gtp_find_pdp(), while using the mutex to protect the PDP context?
Indeed, I forgot about gtp_dev uses rcu. Thanks for explaining.
prev parent reply other threads:[~2026-08-13 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 2:20 [PATCH net v3] gtp: serialize PDP context updates Qing Ming
2026-08-11 2:43 ` Kuniyuki Iwashima
2026-08-11 9:20 ` Pablo Neira Ayuso
2026-08-13 16:31 ` Ming Qing
2026-08-13 17:39 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an4BS0kOJaS1BlXC@chamomile \
--to=pablo@netfilter.org \
--cc=a0yami@mailbox.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.