From: Stefano Garzarella <sgarzare@redhat.com>
To: Nguyen Dinh Phi <phind.uet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/3] vsock: remove the now-unused rejected flag
Date: Fri, 14 Aug 2026 11:04:22 +0200 [thread overview]
Message-ID: <an7aAsvcpoRd00ya@sgarzare-redhat> (raw)
In-Reply-To: <20260813173024.2362935-3-phind.uet@gmail.com>
On Fri, Aug 14, 2026 at 01:30:19AM +0800, Nguyen Dinh Phi wrote:
>After previous patch, the branch marking a socket rejected in
>vsock_accept() is unreachable, and nothing ever sets vsk->rejected
>elsewhere.
>
>In fact, since commit d021c344051a ("VSOCK: Introduce VM Sockets"),
>where `rejected` was introduced, there has never been a path that sets
>sk_err on a listening socket, so that branch has been dead code since
>the beginning.
>
>Therefore, we can remove the `rejected` field from vsock_sock structure.
>
>Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
>Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
>---
> include/net/af_vsock.h | 5 +----
> net/vmw_vsock/af_vsock.c | 46 +++++++++++++---------------------------
> 2 files changed, 16 insertions(+), 35 deletions(-)
Thanks for improving the commit description!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2026-08-14 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 17:30 [PATCH v6 0/3] vsock: fix stale sk_err handling after a failed connect Nguyen Dinh Phi
2026-08-13 17:30 ` [PATCH v6 1/3] vsock: don't check the listener's sk_err in vsock_accept() Nguyen Dinh Phi
2026-08-14 9:03 ` Stefano Garzarella
2026-08-13 17:30 ` [PATCH v6 2/3] vsock: remove the now-unused rejected flag Nguyen Dinh Phi
2026-08-14 9:04 ` Stefano Garzarella [this message]
2026-08-13 17:30 ` [PATCH v6 3/3] vsock: use sock_error() to consume sk_err after a failed connect Nguyen Dinh Phi
2026-08-18 13:00 ` [PATCH v6 0/3] vsock: fix stale sk_err handling " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an7aAsvcpoRd00ya@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phind.uet@gmail.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.