From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 3/7] lib: Add support for max_kver to struct tst_test and tst_fs
Date: Fri, 14 Aug 2026 12:08:44 +0200 [thread overview]
Message-ID: <an7pLCWfdgEPV6G1@yuki.lan> (raw)
In-Reply-To: <20260812130025.GB1758016@pevik>
Hi!
> You're probably right. When I started this there were 3 tests and I thought there
> would be more. I also thought this would be useful info in the metadata. But
> in later versions it turn out 2 of them are to be removed. Now I double checked
> "tst_kvercmp >" code and it looks like none of them applies to .max_kver usage.
> I agree that a single test is not enough as a reason to have it in the metadata.
> Maybe there will be more in the future, but really just a few.
I would set the threshold at at least two tests needs this. If the
functionality is used only by one test, it's likely not worth adding the
API.
> => I should probably send yet another version where I implement the skip in the
> setup. Could you please comment these 2 commits (I would not resend them)?
Which ones?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-14 10:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 16:00 [LTP] [PATCH v5 0/7] Add support for .max_kver Petr Vorel
2026-08-10 16:00 ` [LTP] [PATCH v5 1/7] tst_kvercmp: Factor out error handling Petr Vorel
2026-08-10 16:57 ` [LTP] " linuxtestproject.agent
2026-08-10 17:03 ` Petr Vorel
2026-08-11 7:01 ` [LTP] [PATCH v5 1/7] " Andrea Cervesato via ltp
2026-08-12 10:50 ` Cyril Hrubis
2026-08-10 16:00 ` [LTP] [PATCH v5 2/7] lib: Rename function check_kver() => check_min_kver() Petr Vorel
2026-08-10 16:00 ` [LTP] [PATCH v5 3/7] lib: Add support for max_kver to struct tst_test and tst_fs Petr Vorel
2026-08-11 7:04 ` Andrea Cervesato via ltp
2026-08-12 11:05 ` Cyril Hrubis
2026-08-12 12:30 ` Petr Vorel
2026-08-12 12:36 ` Cyril Hrubis
2026-08-12 13:11 ` Petr Vorel
2026-08-12 12:44 ` Cyril Hrubis
2026-08-12 13:16 ` Petr Vorel
2026-08-12 11:06 ` Cyril Hrubis
2026-08-12 13:00 ` Petr Vorel
2026-08-14 10:08 ` Cyril Hrubis [this message]
2026-08-14 10:40 ` Petr Vorel
2026-08-14 10:50 ` Cyril Hrubis
2026-08-10 16:00 ` [LTP] [PATCH v5 4/7] creat07: Avoid timeout on the test failure Petr Vorel
2026-08-11 7:04 ` Andrea Cervesato via ltp
2026-08-14 10:48 ` Cyril Hrubis
2026-08-10 16:00 ` [LTP] [PATCH v5 5/7] creat07: execve04: Remove version check, add linux-git Petr Vorel
2026-08-14 10:47 ` Cyril Hrubis
2026-08-10 16:00 ` [LTP] [PATCH v5 6/7] fanotify20: Skip on v7.2 Petr Vorel
2026-08-10 16:00 ` [LTP] [PATCH v5 7/7] lib: Add 2 basic tests for .min_kver && .max_kver Petr Vorel
2026-08-11 7:13 ` Andrea Cervesato via ltp
2026-08-11 8:49 ` Petr Vorel
2026-08-11 8:53 ` Andrea Cervesato via ltp
2026-08-11 10:10 ` Avinesh Kumar via ltp
2026-08-11 1:45 ` [LTP] [PATCH v5 0/7] Add support for .max_kver Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an7pLCWfdgEPV6G1@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.