From: Andi Kleen <ak@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 3/4] perf tools: Add support for displaying weights in annotate
Date: Fri, 14 Aug 2026 07:45:15 -0700 [thread overview]
Message-ID: <an8p-1D0jNgE8P4T@tassilo> (raw)
In-Reply-To: <an6zgXlyzPZ_2pI-@google.com>
On Fri, Aug 14, 2026 at 03:19:45PM +0900, Namhyung Kim wrote:
> > * symbol and are missed.
> > @@ -719,6 +720,8 @@ int cmd_annotate(int argc, const char **argv)
> > OPT_BOOLEAN(0, "tui", &annotate.use_tui, "Use the TUI interface"),
> > #endif
> > OPT_BOOLEAN(0, "stdio", &annotate.use_stdio, "Use the stdio interface"),
> > + OPT_BOOLEAN(0, "no-weights", &symbol_conf.hide_weight,
> > + "Hide weight columns in annotation"),
>
> Can it be just "weights"? Then we would get --no-weights for free. :)
> Of course, the help message needs to say differently.
Sure I can rename it.
BTW this was the v2 with the broken white space hunks, please ignore or look at v3.
-Andi
next prev parent reply other threads:[~2026-08-14 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 21:10 Updated patchkit to show weights in annotation Andi Kleen
2026-08-13 21:10 ` [PATCH v2 1/4] perf tools record: Modernize -W man page Andi Kleen
2026-08-14 1:03 ` sashiko-bot
2026-08-13 21:10 ` [PATCH v2 2/4] perf tools top: Add --weight option Andi Kleen
2026-08-14 1:08 ` sashiko-bot
2026-08-13 21:10 ` [PATCH v2 3/4] perf tools: Add support for displaying weights in annotate Andi Kleen
2026-08-14 1:28 ` sashiko-bot
2026-08-14 6:19 ` Namhyung Kim
2026-08-14 14:45 ` Andi Kleen [this message]
2026-08-13 21:10 ` [PATCH v2 4/4] perf tools: Add test for weight annotation Andi Kleen
2026-08-14 1:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an8p-1D0jNgE8P4T@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.