Re: [PATCH v5 22/33] drm/xe/survivability: Report 'boot status' on sysfs failure

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Aug 14, 2026 at 07:17:48PM +0200, Michal Wajdeczko wrote:
> If we fail to create any of the survivability sysfs files, the user
> can't view boot status registers any more. Report them into dmesg
> instead using our existing SIGID helper.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
> Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_survivability_mode.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index 8b74bbc96390..e14553295171 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -305,8 +305,10 @@ static const struct attribute_group survivability_info_group = {
>  
>  static int create_survivability_sysfs(struct pci_dev *pdev)
>  {
> -	struct device *dev = &pdev->dev;
> +	/* Survivability info is required if not enabled via configfs */
> +	bool needs_info = !xe_configfs_get_survivability_mode(pdev);
>  	struct xe_device *xe = pdev_to_xe_device(pdev);
> +	struct device *dev = &pdev->dev;
>  	int ret;
>  
>  	ret = device_create_file(dev, &dev_attr_survivability_mode);
> @@ -318,8 +320,7 @@ static int create_survivability_sysfs(struct pci_dev *pdev)
>  	if (ret)
>  		goto failed;
>  
> -	/* Survivability info is not required if enabled via configfs */
> -	if (!xe_configfs_get_survivability_mode(pdev)) {
> +	if (needs_info) {
>  		ret = devm_device_add_group(dev, &survivability_info_group);
>  		if (ret)
>  			goto failed;
> @@ -329,6 +330,9 @@ static int create_survivability_sysfs(struct pci_dev *pdev)
>  
>  failed:
>  	xe_err(xe, "Failed to create survivability sysfs files: %pe\n", ERR_PTR(ret));
> +	/* no sysfs, dump Survivability info to dmesg instead */
> +	if (needs_info)
> +		log_survivability_info(xe);

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  	return ret;
>  }
>  
> -- 
> 2.47.1
>