All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Shuming [范書銘]" <shumingf@realtek.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"Flove(HsinFu)" <flove@realtek.com>,
	"Oder Chiou" <oder_chiou@realtek.com>,
	"Jack Yu" <jack.yu@realtek.com>,
	"Derek [方德義]" <derek.fang@realtek.com>,
	"pierre-louis.bossart@linux.dev" <pierre-louis.bossart@linux.dev>
Subject: Re: [PATCH v3] ASoC: rt766: add RT766/RT767 SDCA driver
Date: Mon, 3 Aug 2026 09:34:03 +0100	[thread overview]
Message-ID: <anBSe4j6ftGMntSp@opensource.cirrus.com> (raw)
In-Reply-To: <83a748883695468eafd125be3c90d5e3@realtek.com>

On Mon, Aug 03, 2026 at 06:19:02AM +0000, Shuming [范書銘] wrote:
> > > +                     } else {
> > > +                             sdca_irq_free(dev, info, irq,
> > > + interrupt->name, interrupt);
> > 
> > You need to also free the IRQ name allocated by
> > sdca_irq_data_populate() here or it will leak if the jack is re-enabled.
> 
> Thanks for review.
> I will call sdca_irq_cleanup() to free the IRQ.

Would need to be cleanup_late to free the name.

Thanks,
Charles

      reply	other threads:[~2026-08-03  8:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  9:10 [PATCH v3] ASoC: rt766: add RT766/RT767 SDCA driver shumingf
2026-07-31 14:46 ` Charles Keepax
2026-08-03  6:19   ` Shuming [范書銘]
2026-08-03  8:34     ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anBSe4j6ftGMntSp@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.