From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E05D38B14C for ; Mon, 3 Aug 2026 13:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762739; cv=none; b=PCW+nmfXUxwAnE+Fxb4+I/264Msnd62lon28aVO9wk4i6w1C9+ywKHju/DwcXqnJJ488UlycvCTmVGq8kN1fikRTQqQjgVZu51SdDF39XoeoocthgrKBV/RtgAQjcH4inDYKdY8hqMLPoue1GVHHW29saF1cowL+04TZYLFbx64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762739; c=relaxed/simple; bh=PyrcMBjEqokckfH0shgijzNdomu1NbS53nS/jPFEemw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gnQiAmvuHgGzz4B3DQ9zj193zZXuv+01RWiw06pCTbmckDeGjkP8JFhHKiFEJhiwmIYEkSie3eUPfGfOl+t9PTRBkaKG8uxX7fVkhExvCEFZlIdTjOkHeIUT3f3M/nnjRnKeO9au9iNO1wxmGdnf3F2lxRhidZ+U50Y/AMDmRS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qP3Q+ALK; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qP3Q+ALK" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49553515a8bso33312665e9.1 for ; Mon, 03 Aug 2026 06:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785762726; x=1786367526; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=97ECrh6uROUaQf13d9FVHmMobqo4zoNzxlywg2vKSMk=; b=qP3Q+ALKnsIeCFhq16bngMUyBFhqkAPvYN3HXwm+nE+2VJ71GxPdZoIO5Yn5O63FBn Df/jIjdZUvWkw1ZtkbNExSiXbe5v8wHRYQaMA6HkxVdx1+ya7vEylsnql4k8iEesylB6 D8qP8zunX/7nuKLKc5VMvpHlxdaq6e+gn2Od44Gt2luePcmmvhV4uCmn8YhE/MRv3+ad 0SEwC9fmWcaglXGCOvA0Px9oeoVNXAu6SG017CS4GxU/fc1k0+w6gTTJu7SJweIr3rii QNK5ktYfQS8MZ5wEjrIhYUPDpwxc1X71XaFaIhY+dUpJSrv03F6VBasPxDsjZcPMskH0 1C8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785762726; x=1786367526; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=97ECrh6uROUaQf13d9FVHmMobqo4zoNzxlywg2vKSMk=; b=cE2cPL3CYibValQFszm68pbTliexa72PgT8+knzXOgj3fcw3vR7OMM5s9HoXtGbTjY 1D8eN9GQDN6mf+8THVui3JExNGIaFASEz8BPclNlSmccI0PjV47cljHbpJxhO3JuJkP5 k+B1K4f8n+2FUq2ZqTJZjtKnaP/qmEpOXRzV1GkszM2k/gl0cdhhlSNBAH8HyxYWZF8r PA6RgwJqDkPEf0ahcJLFWNxnNpKgr//Py6fG7QQyakyCb5OQrQ2xt3VynkGpQideHc8W uqelblsjGhu7jLHT4QhRtJTOLXoC8suAHGSg4aMo9REMnSOnkGULIEepDgMVYPXssmkO JVsQ== X-Forwarded-Encrypted: i=1; AHgh+RpytgKiyccr1sb+056QjzO5Bavl/uqKPtJMEB0GRrRHA8M9lVE6WNahufuctjKQlaExTWYUxu+KV93IMw==@vger.kernel.org X-Gm-Message-State: AOJu0Yw4bDSlI6mZqAEni7s5GDWCkNn9DX9HX46PswliAoEAYX7rTWhV XIP+6YBSS2oV2gx0ArRlLLeQGnoHt4QF6RaMmyuF7fibWCkLPBytCth7 X-Gm-Gg: AR+sD11yiOVRuCyqhJ6Ikw8RtEDeJ9BwQE1UEgHWQPx372j/QYiaUXCI6Axc+MkJtuF GrEl3W2dS5Ba/AltEL0K6X2I9MmB6E85F8wPfGjFUXkKUMWzJln1pO7SgLv3SBJKmzHoyxsz7MJ tA7rU6eQImtg8ttPc8HghbUgW6uKJWI9THt532/oNDCrj0MCEX3q5rBLS2/zHX9yeZtC1HnZw+3 ih2krRhJjPN3FlduJKjahRdl7oqk1d8jNRsNBIsJqF4oj/vNqkXQeZsuF4YKDoE4PuaXushV3iA kPXwFiIBeqFq7k7+2IiGIMhLUD1w4PYh1Jehtr/HViRvVxr4tuvG/+ws+Om5KrLgDQNYL2qgha4 qviPp6OemlMr3J7qCf7nLRFvoWITpj+y5a9q0gLDh/GtVmo8He7hIBt8q8Zz7zMfcXoQJ+ZF9P1 1HMv0e5TkPTI/ZkW6eQ63xIju9Qwvr2Opk7YZDQ+RLHH1rqlR5Zdpu X-Received: by 2002:a05:600c:46c6:b0:496:c977:3b6d with SMTP id 5b1f17b1804b1-4980c6747f0mr172273935e9.12.1785762725410; Mon, 03 Aug 2026 06:12:05 -0700 (PDT) Received: from nsa ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b6745csm232708385e9.7.2026.08.03.06.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:12:05 -0700 (PDT) Date: Mon, 3 Aug 2026 14:13:14 +0100 From: Nuno =?utf-8?B?U8Oh?= To: phucduc.bui@gmail.com Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , nuno.sa@analog.com, Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Steven Eckhoff , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Linus Walleij , u.kleine-koenig@baylibre.com, Thorsten Blum , Kees Cook , Chen Ni , Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Pengpeng Hou , Richard Fitzgerald , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 01/26] ASoC: codecs: sigmadsp: Use guard() for mutex locks Message-ID: References: <20260727094046.23001-1-phucduc.bui@gmail.com> <20260727094046.23001-2-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260727094046.23001-2-phucduc.bui@gmail.com> On Mon, Jul 27, 2026 at 04:40:21PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > Clean up the code using guard() for mutex locks. > Merely code refactoring, and no behavior change. > > Signed-off-by: bui duc phuc > --- Reviewed-by: Nuno Sá > sound/soc/codecs/sigmadsp.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c > index 2e08fde3989c..b7dbeb237447 100644 > --- a/sound/soc/codecs/sigmadsp.c > +++ b/sound/soc/codecs/sigmadsp.c > @@ -5,6 +5,7 @@ > * Copyright 2009-2014 Analog Devices Inc. > */ > > +#include > #include > #include > #include > @@ -135,7 +136,7 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, > uint8_t *data; > int ret = 0; > > - mutex_lock(&sigmadsp->lock); > + guard(mutex)(&sigmadsp->lock); > > data = ucontrol->value.bytes.data; > > @@ -148,8 +149,6 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, > ctrl->cached = true; > } > > - mutex_unlock(&sigmadsp->lock); > - > return ret; > } > > @@ -160,7 +159,7 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, > struct sigmadsp *sigmadsp = snd_kcontrol_chip(kcontrol); > int ret = 0; > > - mutex_lock(&sigmadsp->lock); > + guard(mutex)(&sigmadsp->lock); > > if (!ctrl->cached) { > ret = sigmadsp_read(sigmadsp, ctrl->addr, ctrl->cache, > @@ -174,8 +173,6 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, > ctrl->num_bytes); > } > > - mutex_unlock(&sigmadsp->lock); > - > return ret; > } > > @@ -677,10 +674,10 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, > return; > changed = snd_ctl_activate_id(card, &ctrl->kcontrol->id, active); > if (active && changed > 0) { > - mutex_lock(&sigmadsp->lock); > - if (ctrl->cached) > - sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); > - mutex_unlock(&sigmadsp->lock); > + scoped_guard(mutex, &sigmadsp->lock) { > + if (ctrl->cached) > + sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); > + } > } > } > > -- > 2.43.0 >