From: Niklas Cassel <cassel@kernel.org>
To: pzalewski@thegoodpenguin.co.uk
Cc: Hans de Goede <hansg@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ata: use named initializers for acpi_device_id
Date: Tue, 4 Aug 2026 11:47:02 +0200 [thread overview]
Message-ID: <anG1FlnTOqxjf9CX@ryzen> (raw)
In-Reply-To: <20260804-ata-acpi-v2-1-8825e646b80d@thegoodpenguin.co.uk>
On Tue, Aug 04, 2026 at 10:44:26AM +0100, Pawel Zalewski via B4 Relay wrote:
> From: "Pawel Zalewski (The Capable Hub)" <pzalewski@thegoodpenguin.co.uk>
>
> Use a named initializer for the acpi_device_id fields which
> makes the code more readable and consistent with how lists
> are initialized in the rest of the kernel code base. Also
> drop explicitly setting fields to 0 where it is redundant.
>
> While we are at it - unify the list terminator to have
> a single space between the brackets and no trailing
> comma.
>
> Signed-off-by: Pawel Zalewski (The Capable Hub) <pzalewski@thegoodpenguin.co.uk>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2026-08-04 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 9:44 [PATCH v2] ata: use named initializers for acpi_device_id Pawel Zalewski via B4 Relay
2026-08-04 9:44 ` Pawel Zalewski (The Capable Hub)
2026-08-04 9:47 ` Niklas Cassel [this message]
2026-08-04 9:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anG1FlnTOqxjf9CX@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hansg@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pzalewski@thegoodpenguin.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.