From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Hongfu Li <hongfu.li@linux.dev>
Cc: akpm@linux-foundation.org, david@kernel.org, liam@infradead.org,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Hongfu Li <lihongfu@kylinos.cn>,
Pedro Falcato <pfalcato@suse.de>
Subject: Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Date: Tue, 4 Aug 2026 09:24:34 +0100 [thread overview]
Message-ID: <anGhWZPDaTP6M_FH@lucifer> (raw)
In-Reply-To: <anGgp9cKiDKDhCpi@lucifer>
On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
> > From: Hongfu Li <lihongfu@kylinos.cn>
> >
> > mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
> > The second run repeats all assertions with no benefit. Drop the
> > duplicate call.
> >
> > Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>
> :))
>
> LGTM so
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Sorry Pedro mentioned off-list that you need to update the number of tests
specified, e.g.:
- ksft_set_plan(88);
+ ksft_set_plan(87);
In main().
Update that and send a respin and you can attach my tag to it.
>
> > ---
> > tools/testing/selftests/mm/mseal_test.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> > index 93c2e13094d4..babc217d9dc9 100644
> > --- a/tools/testing/selftests/mm/mseal_test.c
> > +++ b/tools/testing/selftests/mm/mseal_test.c
> > @@ -1913,7 +1913,6 @@ int main(void)
> > test_seal_mprotect_partial_mprotect(false);
> > test_seal_mprotect_partial_mprotect(true);
> >
> > - test_seal_mprotect_two_vma_with_gap();
> > test_seal_mprotect_two_vma_with_gap();
> >
> > test_seal_mprotect_merge(false);
> > --
> > 2.54.0
> >
>
> --
> Cheers, Lorenzo
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-08-04 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 6:24 [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call Hongfu Li
2026-08-04 8:20 ` Lorenzo Stoakes (ARM)
2026-08-04 8:24 ` Lorenzo Stoakes (ARM) [this message]
2026-08-04 8:51 ` Hongfu Li
2026-08-04 9:25 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anGhWZPDaTP6M_FH@lucifer \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hongfu.li@linux.dev \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.