All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"\"Nuno Sá\"" <nuno.sa@analog.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH 04/44] ASoC: codecs: adau*: use .auto_selectable_formats
Date: Tue, 4 Aug 2026 09:54:28 +0100	[thread overview]
Message-ID: <anGort4nbJekjyq0@nsa> (raw)
In-Reply-To: <877bm6yay6.wl-kuninori.morimoto.gx@renesas.com>

On Tue, Aug 04, 2026 at 12:40:49AM +0000, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---

Acked-by: Nuno Sá <nuno.sa@analog.com>

>  sound/soc/codecs/adau1372.c | 12 ++++++++++++
>  sound/soc/codecs/adau1373.c | 12 ++++++++++++
>  sound/soc/codecs/adau1701.c | 11 +++++++++++
>  sound/soc/codecs/adau17x1.c | 13 +++++++++++++
>  sound/soc/codecs/adau1977.c | 13 +++++++++++++
>  sound/soc/codecs/adau7118.c | 12 ++++++++++++
>  6 files changed, 73 insertions(+)
> 
> diff --git a/sound/soc/codecs/adau1372.c b/sound/soc/codecs/adau1372.c
> index cc174ec3a1f82..0830d7d2dd7c5 100644
> --- a/sound/soc/codecs/adau1372.c
> +++ b/sound/soc/codecs/adau1372.c
> @@ -881,12 +881,24 @@ static const struct snd_soc_component_driver adau1372_driver = {
>  	.endianness = 1,
>  };
>  
> +static const u64 adau1372_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_B	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops adau1372_dai_ops = {
>  	.set_fmt = adau1372_set_dai_fmt,
>  	.set_tdm_slot = adau1372_set_tdm_slot,
>  	.set_tristate = adau1372_set_tristate,
>  	.hw_params = adau1372_hw_params,
>  	.startup = adau1372_startup,
> +	.auto_selectable_formats = &adau1372_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>  };
>  
>  #define ADAU1372_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \
> diff --git a/sound/soc/codecs/adau1373.c b/sound/soc/codecs/adau1373.c
> index 5dd961b233ce9..aa7d3a4b9f588 100644
> --- a/sound/soc/codecs/adau1373.c
> +++ b/sound/soc/codecs/adau1373.c
> @@ -1196,10 +1196,22 @@ static int adau1373_set_dai_sysclk(struct snd_soc_dai *dai,
>  	return 0;
>  }
>  
> +static const u64 adau1373_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_B	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops adau1373_dai_ops = {
>  	.hw_params	= adau1373_hw_params,
>  	.set_sysclk	= adau1373_set_dai_sysclk,
>  	.set_fmt	= adau1373_set_dai_fmt,
> +	.auto_selectable_formats	= &adau1373_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>  };
>  
>  #define ADAU1373_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
> diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
> index 329ab01b62c00..505d52c636278 100644
> --- a/sound/soc/codecs/adau1701.c
> +++ b/sound/soc/codecs/adau1701.c
> @@ -627,11 +627,22 @@ static int adau1701_startup(struct snd_pcm_substream *substream,
>  #define ADAU1701_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\
>  	SNDRV_PCM_FMTBIT_S24_LE)
>  
> +static const u64 adau1701_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops adau1701_dai_ops = {
>  	.set_fmt	= adau1701_set_dai_fmt,
>  	.hw_params	= adau1701_hw_params,
>  	.mute_stream	= adau1701_mute_stream,
>  	.startup	= adau1701_startup,
> +	.auto_selectable_formats	= &adau1701_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>  	.no_capture_mute = 1,
>  };
>  
> diff --git a/sound/soc/codecs/adau17x1.c b/sound/soc/codecs/adau17x1.c
> index 26d7eb437ad18..45ac226b2f1bc 100644
> --- a/sound/soc/codecs/adau17x1.c
> +++ b/sound/soc/codecs/adau17x1.c
> @@ -776,6 +776,17 @@ static int adau17x1_startup(struct snd_pcm_substream *substream,
>  	return 0;
>  }
>  
> +static const u64 adau17x1_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_B	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  const struct snd_soc_dai_ops adau17x1_dai_ops = {
>  	.hw_params	= adau17x1_hw_params,
>  	.set_sysclk	= adau17x1_set_dai_sysclk,
> @@ -783,6 +794,8 @@ const struct snd_soc_dai_ops adau17x1_dai_ops = {
>  	.set_pll	= adau17x1_set_dai_pll,
>  	.set_tdm_slot	= adau17x1_set_dai_tdm_slot,
>  	.startup	= adau17x1_startup,
> +	.auto_selectable_formats	= &adau17x1_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>  };
>  EXPORT_SYMBOL_GPL(adau17x1_dai_ops);
>  
> diff --git a/sound/soc/codecs/adau1977.c b/sound/soc/codecs/adau1977.c
> index b42f35b1a6036..b9d9853934216 100644
> --- a/sound/soc/codecs/adau1977.c
> +++ b/sound/soc/codecs/adau1977.c
> @@ -741,6 +741,17 @@ static int adau1977_set_tristate(struct snd_soc_dai *dai, int tristate)
>  		ADAU1977_SAI_OVERTEMP_DRV_HIZ, val);
>  }
>  
> +static const u64 adau1977_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_B	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops adau1977_dai_ops = {
>  	.startup	= adau1977_startup,
>  	.hw_params	= adau1977_hw_params,
> @@ -748,6 +759,8 @@ static const struct snd_soc_dai_ops adau1977_dai_ops = {
>  	.set_fmt	= adau1977_set_dai_fmt,
>  	.set_tdm_slot	= adau1977_set_tdm_slot,
>  	.set_tristate	= adau1977_set_tristate,
> +	.auto_selectable_formats	= &adau1977_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>  };
>  
>  static struct snd_soc_dai_driver adau1977_dai = {
> diff --git a/sound/soc/codecs/adau7118.c b/sound/soc/codecs/adau7118.c
> index 5ddea63a6612c..9749299bc7f2a 100644
> --- a/sound/soc/codecs/adau7118.c
> +++ b/sound/soc/codecs/adau7118.c
> @@ -418,12 +418,24 @@ static int adau7118_component_probe(struct snd_soc_component *component)
>  	return ret;
>  }
>  
> +static const u64 adau7118_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops adau7118_ops = {
>  	.hw_params = adau7118_hw_params,
>  	.set_channel_map = adau7118_set_channel_map,
>  	.set_fmt = adau7118_set_fmt,
>  	.set_tdm_slot = adau7118_set_tdm_slot,
>  	.set_tristate = adau7118_set_tristate,
> +	.auto_selectable_formats = &adau7118_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>  };
>  
>  static struct snd_soc_dai_driver adau7118_dai = {
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-08-04  8:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  0:40 [PATCH 00/44] ASoC: codec: use .auto_selectable_formats Kuninori Morimoto
2026-08-04  0:40 ` [PATCH 01/44] ASoC: codecs: 88pm860x: " Kuninori Morimoto
2026-08-04  0:40 ` [PATCH 02/44] ASoC: codecs: ad1*: " Kuninori Morimoto
2026-08-04  8:52   ` Nuno Sá
2026-08-04  0:40 ` [PATCH 03/44] ASoC: codecs: ab8500: " Kuninori Morimoto
2026-08-04  0:40 ` [PATCH 04/44] ASoC: codecs: adau*: " Kuninori Morimoto
2026-08-04  8:54   ` Nuno Sá [this message]
2026-08-04  0:40 ` [PATCH 05/44] ASoC: codecs: adav80x: " Kuninori Morimoto
2026-08-04  8:55   ` Nuno Sá
2026-08-04  0:40 ` [PATCH 06/44] ASoC: codecs: ak4*: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 07/44] ASoC: codecs: ak5*: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 08/44] ASoC: codecs: alc56*: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 09/44] ASoC: codecs: arizona: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 10/44] ASoC: codecs: cpcap: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 11/44] ASoC: codecs: cros_ec_codec: " Kuninori Morimoto
2026-08-04  3:04   ` Tzung-Bi Shih
2026-08-04  0:41 ` [PATCH 12/44] ASoC: codecs: cs35l*: " Kuninori Morimoto
2026-08-04 17:30   ` Mark Brown
2026-08-04  0:41 ` [PATCH 13/44] ASoC: codecs: cs42*: " Kuninori Morimoto
2026-08-04 17:32   ` Mark Brown
2026-08-04  0:41 ` [PATCH 14/44] ASoC: codecs: cs5*: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 15/44] ASoC: codecs: cx2072x: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 16/44] ASoC: codecs: da*: " Kuninori Morimoto
2026-08-04  0:41 ` [PATCH 17/44] ASoC: codecs: es*: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 18/44] ASoC: codecs: inno_rk3036: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 19/44] ASoC: codecs: isabelle: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 20/44] ASoC: codecs: lm49453: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 21/44] ASoC: codecs: lochnagar-sc: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 22/44] ASoC: codecs: madera: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 23/44] ASoC: codecs: max*: " Kuninori Morimoto
2026-08-04 17:37   ` Mark Brown
2026-08-07  5:29     ` Peter Rosin
2026-08-04  0:42 ` [PATCH 24/44] ASoC: codecs: mc13783: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 25/44] ASoC: codecs: ml26124: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 26/44] ASoC: codecs: nau*: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 27/44] ASoC: codecs: ntp8*: " Kuninori Morimoto
2026-08-04  0:42 ` [PATCH 28/44] ASoC: codecs: rk33*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 29/44] ASoC: codecs: rtq912*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 30/44] ASoC: codecs: rt*: " Kuninori Morimoto
2026-08-04 17:39   ` Mark Brown
2026-08-04  0:43 ` [PATCH 31/44] ASoC: codecs: sgtl5000: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 32/44] ASoC: codecs: si476x: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 33/44] ASoC: codecs: sma130*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 34/44] ASoC: codecs: src4xxx: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 35/44] ASoC: codecs: ssm*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 36/44] ASoC: codecs: sta*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 37/44] ASoC: codecs: tas*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 38/44] ASoC: codecs: tfa9879: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 39/44] ASoC: codecs: tlv320*: " Kuninori Morimoto
2026-08-04  0:43 ` [PATCH 40/44] ASoC: codecs: tscs454: " Kuninori Morimoto
2026-08-04  0:44 ` [PATCH 41/44] ASoC: codecs: twl4030: " Kuninori Morimoto
2026-08-04  0:44 ` [PATCH 42/44] ASoC: codecs: uda13*: " Kuninori Morimoto
2026-08-04  0:44 ` [PATCH 43/44] ASoC: codecs: wm*: " Kuninori Morimoto
2026-08-04 17:40   ` Mark Brown
2026-08-05  4:25     ` Kuninori Morimoto
2026-08-04  0:44 ` [PATCH 44/44] ASoC: codecs: zl38060: " Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anGort4nbJekjyq0@nsa \
    --to=noname.nuno@gmail.com \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.