From: Thorsten Blum <thorsten.blum@linux.dev>
To: Helge Deller <deller@gmx.de>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h
Date: Tue, 4 Aug 2026 15:37:40 +0200 [thread overview]
Message-ID: <anHrJM1roOI_34cc@linux.dev> (raw)
In-Reply-To: <eb470716-e6df-4468-ab23-4902f26a9bac@gmx.de>
On Tue, Aug 04, 2026 at 03:29:51PM +0200, Helge Deller wrote:
> Hi Thorsten,
>
> On 8/4/26 15:20, Thorsten Blum wrote:
> > Include asm-generic/serial.h and use the generic BASE_BAUD definition
> > instead of redefining it.
> >
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > ---
> > arch/parisc/include/asm/serial.h | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h
> and adding the patch below the better approach?
It was a single patch at some point, but since serial.h is otherwise
empty, your approach seems a lot nicer. I'll send a v2.
Thanks,
Thorsten
> diff --git a/arch/parisc/include/asm/Kbuild b/arch/parisc/include/asm/Kbuild
> index d48d158f7241..4fc315085914 100644
> --- a/arch/parisc/include/asm/Kbuild
> +++ b/arch/parisc/include/asm/Kbuild
> @@ -6,3 +6,4 @@ generic-y += kvm_para.h
> generic-y += mcs_spinlock.h
> generic-y += ring_buffer.h
> generic-y += user.h
> +generic-y += serial.h
prev parent reply other threads:[~2026-08-04 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 13:20 [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h Thorsten Blum
2026-08-04 13:20 ` [PATCH 2/3] parisc/serial: Add include guard to asm/serial.h Thorsten Blum
2026-08-04 13:20 ` [PATCH 3/3] parisc/serial: Add SPDX license identifier " Thorsten Blum
2026-08-04 13:29 ` [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h Helge Deller
2026-08-04 13:37 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anHrJM1roOI_34cc@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.