All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Felix Maurer <fmaurer@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	 kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	bigeasy@linutronix.de,  fmancera@suse.de, luka.gejak@linux.dev,
	xiaoliang.yang_1@nxp.com,  kexinsun@smail.nju.edu.cn,
	ssrane_b23@ee.vjti.ac.in, michael.bommarito@gmail.com,
	 2022090917019@std.uestc.edu.cn, yury.norov@gmail.com,
	jvaclav@redhat.com, maoyixie.tju@gmail.com
Subject: Re: [RFC net-next 0/2] hsr: Use only one MAC address per node
Date: Wed, 5 Aug 2026 10:50:25 +0800	[thread overview]
Message-ID: <anKiHmSnUjBOw1f2@fedora> (raw)
In-Reply-To: <cover.1784024900.git.fmaurer@redhat.com>

Hi Felix,
On 14.07.2026 12:52, Felix Maurer wrote:
>To prevent misconfiguration and simplify the hsr code, this patchset
>removes the notion of two different MAC addresses for one node in the
>network entirely. The first patch sets equal addresses on both ports so
>that we are not running in invalid configurations. I also updates the
>selftest to not use/expect different addresses on the two ports. The
>second patch removes MAC address B from the node table and thereby
>eliminates a lot of code, including the node merging.
>
>I am posting as an RFC for now mostly for two reasons: First, I want to
>make sure it's generally accepted to have only a single MAC address per
>node and give everyone the chance to speak up against this.
>
>Second, I adapted the PRP address handling to HSR as well, i.e., to copy
>the address from port A to port B and master, mostly because it is low
>effort. I am not sure though if this is the best approach now that we

+1 for this behavior. Bonding also use this one as default behavior.

Thanks
Hangbin

      parent reply	other threads:[~2026-08-05  2:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 10:52 [RFC net-next 0/2] hsr: Use only one MAC address per node Felix Maurer
2026-07-14 10:52 ` [RFC net-next 1/2] hsr: Set equal MAC addresses on port A and B for HSR Felix Maurer
2026-07-14 10:52 ` [RFC net-next 2/2] hsr: Remove second MAC address from node table Felix Maurer
2026-08-04 13:18 ` [RFC net-next 0/2] hsr: Use only one MAC address per node Fernando Fernandez Mancera
2026-08-05  2:50 ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anKiHmSnUjBOw1f2@fedora \
    --to=liuhangbin@gmail.com \
    --cc=2022090917019@std.uestc.edu.cn \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=fmaurer@redhat.com \
    --cc=horms@kernel.org \
    --cc=jvaclav@redhat.com \
    --cc=kexinsun@smail.nju.edu.cn \
    --cc=kuba@kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=maoyixie.tju@gmail.com \
    --cc=michael.bommarito@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ssrane_b23@ee.vjti.ac.in \
    --cc=xiaoliang.yang_1@nxp.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.