From: Alice Ryhl <aliceryhl@google.com>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Ke Sun" <sunke@kylinos.cn>, "Boqun Feng" <boqun@kernel.org>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH RESEND v13 0/2] rust: Add safe pointer formatting support
Date: Wed, 5 Aug 2026 08:16:30 +0000 [thread overview]
Message-ID: <anLxXvCKBcAVf91_@google.com> (raw)
In-Reply-To: <20260706-hashedptr-v13-0-377a07f2f78d@kylinos.cn>
On Mon, Jul 06, 2026 at 01:18:42PM +0800, Ke Sun wrote:
> This series fixes two issues with {:p} pointer formatting:
> - The impl_fmt_adapter_forward! macro destructures self into a local
> variable, causing {:p} to print a stack address instead of the actual
> pointer
> - Kernel address leak — {:p} prints raw pointer values, exposing kernel
> address space layout
I got:
rust/kernel.o: error: objtool: _RNvXs4_NtCskVLJmUDtH0q_6kernel3fmtINtB5_7AdapterRPhENtNtCsfr3MPOfBGpN_4core3fmt7Pointer3fmtB7_() falls through to next function _RNvXs4_NtCskVLJmUDtH0q_6kernel3strShINtNtCsfr3MPOfBGpN_4core7convert5AsRefNtB5_4BStrE6as_ref()
when I built this on x86_64. Miguel, are we missing a function in the
list of noreturn functions?
Alice
next prev parent reply other threads:[~2026-08-05 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 5:18 [PATCH RESEND v13 0/2] rust: Add safe pointer formatting support Ke Sun
2026-07-06 5:18 ` [PATCH RESEND v13 1/2] rust: fmt: fix {:p} printing stack addresses Ke Sun
2026-08-05 8:15 ` Alice Ryhl
2026-08-06 14:14 ` Gary Guo
2026-07-06 5:18 ` [PATCH RESEND v13 2/2] rust: fmt: route {:p} through HashedPtr to prevent address leaks Ke Sun
2026-08-05 8:15 ` Alice Ryhl
2026-08-06 14:24 ` Link Mauve
2026-08-07 7:45 ` Alvin Sun
2026-08-07 8:01 ` Ke Sun
2026-08-06 14:41 ` Gary Guo
2026-08-07 7:32 ` Ke Sun
2026-08-05 8:16 ` Alice Ryhl [this message]
2026-08-05 12:30 ` [PATCH RESEND v13 0/2] rust: Add safe pointer formatting support Miguel Ojeda
2026-08-05 14:48 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anLxXvCKBcAVf91_@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sunke@kylinos.cn \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.