From: "Nuno Sá" <noname.nuno@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-sound@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: adau1761: sort the register default table
Date: Wed, 5 Aug 2026 14:30:26 +0100 [thread overview]
Message-ID: <anM63ohN5_iJeAPX@nsa> (raw)
In-Reply-To: <20260805122713.11376-1-peter.ujfalusi@linux.intel.com>
On Wed, Aug 05, 2026 at 03:27:13PM +0300, Peter Ujfalusi wrote:
> reg_defaults must be sorted by ascending register address, as
> regcache_lookup_reg() locates entries in it with bsearch(). See commit
> fd80df352ba1 ("regcache: Add support for sorting defaults arrays").
>
> The table lists the ADAU1761 specific registers (0x4008 and up) before
> the block shared with the ADAU1381/ADAU1781, which starts at
> ADAU17X1_CLOCK_CONTROL (0x4000), so bsearch() descends into the wrong
> half and 28 of the 52 entries are unreachable.
> regcache_reg_needs_sync() then cannot compare them against their default
> and reports that a sync is needed, so they are written to the device on
> every regcache_sync() even when they were never touched.
>
> Sort the table by register address.
>
> Fixes: dab464b60b24 ("ASoC: Add ADAU1361/ADAU1761 audio CODEC support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
Acked-by: Nuno Sá <nuno.sa@analog.com>
> sound/soc/codecs/adau1761.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/sound/soc/codecs/adau1761.c b/sound/soc/codecs/adau1761.c
> index a70c46dd5d76..27ce03b0fb91 100644
> --- a/sound/soc/codecs/adau1761.c
> +++ b/sound/soc/codecs/adau1761.c
> @@ -68,23 +68,33 @@
> #define ADAU1761_FIRMWARE "adau1761.bin"
>
> static const struct reg_default adau1761_reg_defaults[] = {
> - { ADAU1761_DEJITTER, 0x03 },
> + { ADAU17X1_CLOCK_CONTROL, 0x00 },
> + { ADAU17X1_PLL_CONTROL, 0x00 },
> { ADAU1761_DIGMIC_JACKDETECT, 0x00 },
> + { ADAU17X1_REC_POWER_MGMT, 0x00 },
> { ADAU1761_REC_MIXER_LEFT0, 0x00 },
> { ADAU1761_REC_MIXER_LEFT1, 0x00 },
> { ADAU1761_REC_MIXER_RIGHT0, 0x00 },
> { ADAU1761_REC_MIXER_RIGHT1, 0x00 },
> { ADAU1761_LEFT_DIFF_INPUT_VOL, 0x00 },
> + { ADAU1761_RIGHT_DIFF_INPUT_VOL, 0x00 },
> + { ADAU17X1_MICBIAS, 0x00 },
> { ADAU1761_ALC_CTRL0, 0x00 },
> { ADAU1761_ALC_CTRL1, 0x00 },
> { ADAU1761_ALC_CTRL2, 0x00 },
> { ADAU1761_ALC_CTRL3, 0x00 },
> - { ADAU1761_RIGHT_DIFF_INPUT_VOL, 0x00 },
> - { ADAU1761_PLAY_LR_MIXER_LEFT, 0x00 },
> + { ADAU17X1_SERIAL_PORT0, 0x00 },
> + { ADAU17X1_SERIAL_PORT1, 0x00 },
> + { ADAU17X1_CONVERTER0, 0x00 },
> + { ADAU17X1_CONVERTER1, 0x00 },
> + { ADAU17X1_ADC_CONTROL, 0x00 },
> + { ADAU17X1_LEFT_INPUT_DIGITAL_VOL, 0x00 },
> + { ADAU17X1_RIGHT_INPUT_DIGITAL_VOL, 0x00 },
> { ADAU1761_PLAY_MIXER_LEFT0, 0x00 },
> { ADAU1761_PLAY_MIXER_LEFT1, 0x00 },
> { ADAU1761_PLAY_MIXER_RIGHT0, 0x00 },
> { ADAU1761_PLAY_MIXER_RIGHT1, 0x00 },
> + { ADAU1761_PLAY_LR_MIXER_LEFT, 0x00 },
> { ADAU1761_PLAY_LR_MIXER_RIGHT, 0x00 },
> { ADAU1761_PLAY_MIXER_MONO, 0x00 },
> { ADAU1761_PLAY_HP_LEFT_VOL, 0x00 },
> @@ -93,20 +103,6 @@ static const struct reg_default adau1761_reg_defaults[] = {
> { ADAU1761_PLAY_LINE_RIGHT_VOL, 0x00 },
> { ADAU1761_PLAY_MONO_OUTPUT_VOL, 0x00 },
> { ADAU1761_POP_CLICK_SUPPRESS, 0x00 },
> - { ADAU1761_JACK_DETECT_PIN, 0x00 },
> - { ADAU1761_CLK_ENABLE0, 0x00 },
> - { ADAU1761_CLK_ENABLE1, 0x00 },
> - { ADAU17X1_CLOCK_CONTROL, 0x00 },
> - { ADAU17X1_PLL_CONTROL, 0x00 },
> - { ADAU17X1_REC_POWER_MGMT, 0x00 },
> - { ADAU17X1_MICBIAS, 0x00 },
> - { ADAU17X1_SERIAL_PORT0, 0x00 },
> - { ADAU17X1_SERIAL_PORT1, 0x00 },
> - { ADAU17X1_CONVERTER0, 0x00 },
> - { ADAU17X1_CONVERTER1, 0x00 },
> - { ADAU17X1_LEFT_INPUT_DIGITAL_VOL, 0x00 },
> - { ADAU17X1_RIGHT_INPUT_DIGITAL_VOL, 0x00 },
> - { ADAU17X1_ADC_CONTROL, 0x00 },
> { ADAU17X1_PLAY_POWER_MGMT, 0x00 },
> { ADAU17X1_DAC_CONTROL0, 0x00 },
> { ADAU17X1_DAC_CONTROL1, 0x00 },
> @@ -114,12 +110,16 @@ static const struct reg_default adau1761_reg_defaults[] = {
> { ADAU17X1_SERIAL_PORT_PAD, 0xaa },
> { ADAU17X1_CONTROL_PORT_PAD0, 0xaa },
> { ADAU17X1_CONTROL_PORT_PAD1, 0x00 },
> + { ADAU1761_JACK_DETECT_PIN, 0x00 },
> + { ADAU1761_DEJITTER, 0x03 },
> { ADAU17X1_DSP_SAMPLING_RATE, 0x01 },
> { ADAU17X1_SERIAL_INPUT_ROUTE, 0x00 },
> { ADAU17X1_SERIAL_OUTPUT_ROUTE, 0x00 },
> { ADAU17X1_DSP_ENABLE, 0x00 },
> { ADAU17X1_DSP_RUN, 0x00 },
> { ADAU17X1_SERIAL_SAMPLING_RATE, 0x00 },
> + { ADAU1761_CLK_ENABLE0, 0x00 },
> + { ADAU1761_CLK_ENABLE1, 0x00 },
> };
>
> static const DECLARE_TLV_DB_SCALE(adau1761_sing_in_tlv, -1500, 300, 1);
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-08-05 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 12:27 [PATCH] ASoC: adau1761: sort the register default table Peter Ujfalusi
2026-08-05 13:30 ` Nuno Sá [this message]
2026-08-05 16:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anM63ohN5_iJeAPX@nsa \
--to=noname.nuno@gmail.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.