From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Steve Kaznak <skaznak@protonmail.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, johannes.goede@oss.qualcomm.com,
hverkuil+cisco@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: Add OV01A1B sensor config
Date: Wed, 5 Aug 2026 12:54:49 +0200 [thread overview]
Message-ID: <anMVPKGx64O-brRP@mdjait-mobl> (raw)
In-Reply-To: <20260805021154.51404-1-skaznak@protonmail.com>
Hello Steve,
Thank you for the patch!
On Wed, Aug 05, 2026 at 02:12:15AM +0000, Steve Kaznak wrote:
> Add the Omnivision OV01A1B (ACPI HID OVTI01AB) to the
> ipu_supported_sensors[] table, with the same single 400 MHz link
> frequency as the OV01A10 and OV01A1S entries it shares a comment with.
>
> The sensor is the IR camera in the Dell XPS 13 Plus 9320, behind an
> Intel Vision Sensing Controller (IVSC). Commit 36eab90d3f4f ("media:
> i2c: ov01a10: Add ov01a1b support") added driver support for it, but
> without a bridge entry no fwnode graph endpoint is created, so the
> driver never binds and the camera is not enumerated.
>
> Tested on an XPS 13 Plus 9320: the sensor binds and streams 1296x816
> Y10 at 30 fps.
>
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
> Signed-off-by: Steve Kaznak <skaznak@protonmail.com>
> ---
> drivers/media/pci/intel/ipu-bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index 88581a4c081d..7a1e3cb30721 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -73,9 +73,10 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = {
> IPU_SENSOR_CONFIG("INT3537", 1, 437000000),
> /* Lontium lt6911uxe */
> IPU_SENSOR_CONFIG("INTC10C5", 0),
> - /* Omnivision OV01A10 / OV01A1S */
> + /* Omnivision OV01A10 / OV01A1S / OV01A1B */
> IPU_SENSOR_CONFIG("OVTI01A0", 1, 400000000),
> IPU_SENSOR_CONFIG("OVTI01AS", 1, 400000000),
> + IPU_SENSOR_CONFIG("OVTI01AB", 1, 400000000),
small nit: The table states that * Please keep the list sorted by ACPI HID
so OVTI01AB should go first
IPU_SENSOR_CONFIG("OVTI01AB", 1, 400000000),
IPU_SENSOR_CONFIG("OVTI01AS", 1, 400000000),
> /* Omnivision OV02C10 */
> IPU_SENSOR_CONFIG("OVTI02C1", 1, 400000000),
> /* Omnivision OV02E10 */
--
Kind Regards
Mehdi Djait
prev parent reply other threads:[~2026-08-05 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 2:12 [PATCH] media: ipu-bridge: Add OV01A1B sensor config Steve Kaznak
2026-08-05 10:54 ` Mehdi Djait [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anMVPKGx64O-brRP@mdjait-mobl \
--to=mehdi.djait@linux.intel.com \
--cc=hverkuil+cisco@kernel.org \
--cc=johannes.goede@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=skaznak@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.