From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B374C55ABA for ; Wed, 5 Aug 2026 14:06:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrcG5-00067Z-K2; Wed, 05 Aug 2026 10:06:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrcG3-00066J-Oh for qemu-devel@nongnu.org; Wed, 05 Aug 2026 10:06:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrcG1-0003Bq-7V for qemu-devel@nongnu.org; Wed, 05 Aug 2026 10:06:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785938767; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=H6XFI2n/5Lb3GPIXzdtWuoNVPUTnZT9ZtQeqOnVSIXQ=; b=QhDmlyapxl+NhVyTK/GbWQph33jhKdEiqYq0D0S9aw4Va7sENW2PO2rip15v/hl2FdIYqG rz8K/A2C/kGFEbBVOX/S19qj9i+HyeWNNGxj6NpKHkEpgVSgnDZAVyP6E2nMQSHHVcxsvD XeeWcJydAgksWKi5VmqyhhqFs19NHs0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-bUUYI8WmNBqpRWjktoxJBw-1; Wed, 05 Aug 2026 10:05:49 -0400 X-MC-Unique: bUUYI8WmNBqpRWjktoxJBw-1 X-Mimecast-MFC-AGG-ID: bUUYI8WmNBqpRWjktoxJBw_1785938747 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C60C18009D3; Wed, 5 Aug 2026 14:05:47 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.46]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 727E83000239; Wed, 5 Aug 2026 14:05:43 +0000 (UTC) Date: Wed, 5 Aug 2026 15:05:39 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Nicholas Piggin , Daniel Henrique Barboza , Bernhard Beschow , Anton Johansson , Alistair Francis , Peter Maydell , Alistair Francis Subject: Re: [PATCH 01/27] include/qemu/target-info-qom.h: declare TYPE_TARGET_SPECIFIC interface Message-ID: References: <20260724000948.234657-1-pierrick.bouvier@oss.qualcomm.com> <20260724000948.234657-2-pierrick.bouvier@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260724000948.234657-2-pierrick.bouvier@oss.qualcomm.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.852, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jul 24, 2026 at 12:09:21AM +0000, Pierrick Bouvier wrote: > In the next commits, We'll replace the logic to filter QOM types per > target from a static one (based on INTERFACES) to a runtime one, based > on is_available() function, that can be overriden per class. > > Introduce the new interface we'll use for that. > > Signed-off-by: Pierrick Bouvier > --- > include/qemu/target-info-qom.h | 15 +++++++++++++++ > target-info-qom.c | 5 +++++ > 2 files changed, 20 insertions(+) > > diff --git a/include/qemu/target-info-qom.h b/include/qemu/target-info-qom.h > index 91be415ed33..83eb537333b 100644 > --- a/include/qemu/target-info-qom.h > +++ b/include/qemu/target-info-qom.h > @@ -14,6 +14,21 @@ > > #define TYPE_TARGET_INFO "target-info" > > +#define TYPE_TARGET_SPECIFIC "target-specific" > + > +typedef struct TargetSpecific TargetSpecific; > + > +typedef struct TargetSpecificClass { > + InterfaceClass parent_class; > + > + bool (*is_available)(void); > +} TargetSpecificClass; > + > +#define TARGET_SPECIFIC(obj) \ > + INTERFACE_CHECK(TargetSpecific, (obj), TYPE_TARGET_SPECIFIC) > +DECLARE_CLASS_CHECKERS(TargetSpecificClass, TARGET_SPECIFIC, > + TYPE_TARGET_SPECIFIC) Looking through the series,I don't really see the point in this interface. Why is this not possible to do by adding 'is_available' to MachineClass. It would make the rest of the series simpler and especially avoid the need to introduced yet more series of macros for defining machine classes. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|