From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89243C55174 for ; Wed, 5 Aug 2026 23:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=usxwI1tA1nzZywB+IahecfbkA5obcrn9U7WVrapcMxc=; b=ehXgO5q2rhD4Lt yViJHrSqYOG0Dz3AnKto9WlSqY2fWX6z3/E6ILYwcjE1MjEbuiPfDwHg2ACW0pMoRYAW9KxkGMwRo dmPKiLSrqTOwiKr1hOfZTPEDPw3ZYvTuamzelqipPHWIsZA7jT/VURTqQaunjMA2+JZfRCWSifNIh O33lRTneprlehqWhGyReRdJU1Wr6UWB8E0GuUWCAn8hgVJV57VqDpoZdbG5gFbDKPRKXyxYJeiUCS cC/4w+ENB3XpevyeDN+d0s3Ea/4swppEiESv8f8lToPeti+K+lcTHxXXjga6AkQBPkzVUaCVlom05 wwhYzWskD7LD51mUzjvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrkju-00000004dUJ-3W1n; Wed, 05 Aug 2026 23:09:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrkjs-00000004dTY-0nWn for linux-rockchip@lists.infradead.org; Wed, 05 Aug 2026 23:09:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785971369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P5KkfoazfSd7LbFAmZXs7FVBEh30eBrbBqu13ZxDK8Q=; b=QKszLQKHTkqU8jIZFdAWkoirZQ7m0eacUrrlGq74E2I+MMeHzDgP6V5/jMfJYg4G1n7Lhq tQP8hHwn31Ri5umuGO2V3jXDC+Zf9j09nEqUh/OouZ9EDgjUTuM9Xq0TVgc+FNgJ5IGJMI bitEZL4vTdXArxvssBNBUkSS7cxEok4= Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-mcV6x2mYMaKkhCGlNnQa6Q-1; Wed, 05 Aug 2026 19:09:27 -0400 X-MC-Unique: mcV6x2mYMaKkhCGlNnQa6Q-1 X-Mimecast-MFC-AGG-ID: mcV6x2mYMaKkhCGlNnQa6Q_1785971367 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-669864510f5so1732930d50.2 for ; Wed, 05 Aug 2026 16:09:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785971367; x=1786576167; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=P5KkfoazfSd7LbFAmZXs7FVBEh30eBrbBqu13ZxDK8Q=; b=XWqs2gihGm9zDQZcJTmQviopfLGBnahwtVUyAFfeXcQCLMtlo1j3/U72n0h+Id66K/ HWiVV2hm0IoONBEGPv3DclmntelgCMHnX8j7IblAQyhx0xfMAgdSBw52HH7mIPJzDBN9 hJrlAROZBioe9kuM6GN3IWcCM3ACv8HVO0ggcOaBSuDPyESZVcRx0Bh9gd8ptqeNAWtX lLfi9VemYeoYIEWafJQ1m3soAQpMMQNaO+MX5O7muU9eWgcm0WvTMl2BdehN/fRA5VQ3 sd4nUprV5xV4NjlnHQVdWVnJGNujLyWXf+MIoUHtuMTg64EjQP7i30SAI83ydY96gADh OteA== X-Forwarded-Encrypted: i=1; AHgh+Rrv8hnkoLQ/NpLd+ecCc5a619lMr6+zsfUZSf0+BPTmdFRiTc5/+z2qgt0+2xcYYqZWRHqzwYgaTVTzb6oqMw==@lists.infradead.org X-Gm-Message-State: AOJu0Yx5jFtnePpNiQBT4Wam/oF5YZPprMyvgPnaCPljcCbjMmxBdI/r wdrTUph1CZjOVMJWMb9GGJrLDYikI8pysQpvzf5/lxH8Lhm2+Xk8R3j44qUk4P+YcEmlx4SQpO3 4tQw0bhyI9SXng+cbnUUmv7LDgM74abE6/ZvmNvix21Cd7iLrAfuuWK8ajqrXSVyzrq7R+fX0d8 wi3PhzLw== X-Gm-Gg: AR+sD11nV1monMjqxR/LsyKeUbktPxgtoKqMBiy1iDMp34FHId3E3rmAyqEGxKxnlej 7UdB6JwNiZsg73HnAI3jeHb8UrPxZ7ivNbFDzQK7SCYI9e0VLbUIJUualtIxTEmRjLAX3CKNOB4 y7u+boWKOCwIrb1hwzFj4HnNDirHXo3POPV3/NQXGdt6QQqwz/+WpdFHbNMuicwrSJOr4bFSxVy Bl6Ys3c3OyTvgawuwcifvmb0KyG76QPRP0l9HvD36u6vF5G+uckmxhA+7PZSpdKXicCN9/bY3j5 DVt1QRTmcBMKX6+o7OrMvvgMBdGFbvim9YkOTqD+7mb9KThsP77OnrLCcUve4+/MV0V65Gx0LV+ QFJ970P8fmJv4RT3/bSdF9amWKDJoXdBh3Rk= X-Received: by 2002:a05:690e:250b:10b0:667:a95b:59f0 with SMTP id 956f58d0204a3-6699abcfe28mr5022129d50.34.1785971366743; Wed, 05 Aug 2026 16:09:26 -0700 (PDT) X-Received: by 2002:a05:690e:250b:10b0:667:a95b:59f0 with SMTP id 956f58d0204a3-6699abcfe28mr5022102d50.34.1785971366332; Wed, 05 Aug 2026 16:09:26 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-669913b9903sm3924589d50.7.2026.08.05.16.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 16:09:25 -0700 (PDT) Date: Wed, 5 Aug 2026 19:09:23 -0400 From: Brian Masney To: Chen-Yu Tsai Cc: Heiko Stuebner , Michael Turquette , Stephen Boyd , Daniele Briguglio , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas , Nicolas Frattaroli , Ricardo Pardini Subject: Re: [PATCH] clk: rockchip: rk3588: don't disable unused I2S MCLK output gates Message-ID: References: <20260624123914.1767374-1-hello@superkali.me> <178267399833.3089434.5140309637329023610.b4-ty@sntech.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: esDG1hgkdHtk4Is36heWT9993EiqOKnS26avNMb5cok_1785971367 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260805_160932_305668_889FE355 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgQ2hlbi1ZdSwKCk9uIFRodSwgQXVnIDA2LCAyMDI2IGF0IDAxOjAwOjAyQU0gKzA4MDAsIENo ZW4tWXUgVHNhaSB3cm90ZToKPiBPbiBNb24sIEp1biAyOSwgMjAyNiBhdCAzOjEz4oCvQU0gSGVp a28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4gd3JvdGU6Cj4gPgo+ID4KPiA+IE9uIFdlZCwg MjQgSnVuIDIwMjYgMTQ6Mzk6MTQgKzAyMDAsIERhbmllbGUgQnJpZ3VnbGlvIHdyb3RlOgo+ID4g PiBObyBpbi10cmVlIGJvYXJkIHJlZmVyZW5jZXMgdGhlc2UgZ2F0ZXMgeWV0LiBCb2FyZHMgZHJp dmUgdGhlIGNvZGVjCj4gPiA+IE1DTEsgdGhyb3VnaCB0aGUgcGFyZW50IEkyUypfOENIX01DTEtP VVQsIGFuZCBub3cgdGhhdCB0aGUgZ2F0ZXMgYXJlCj4gPiA+IG1hbmFnZWQgY2xvY2tzLCBjbGtf ZGlzYWJsZV91bnVzZWQoKSB0dXJucyB0aGVtIG9mZiBhdCBib290LiBPbiBhIGJvYXJkCj4gPiA+ IHRoYXQgcmVsaWVkIG9uIGZpcm13YXJlIGxlYXZpbmcgdGhlIG91dHB1dCBlbmFibGVkLCB0aGF0 IGN1dHMgdGhlIE1DTEsKPiA+ID4gYW5kIGFuYWxvZyBhdWRpbyBzdG9wcyB3b3JraW5nLgo+ID4g Pgo+ID4gPiBNYXJrIHRoZSBmb3VyIGdhdGVzIENMS19JR05PUkVfVU5VU0VEIHNvIGFuIHVucmVm ZXJlbmNlZCBnYXRlIGtlZXBzIHRoZQo+ID4gPiBzdGF0ZSBmaXJtd2FyZSBsZWZ0LiBBIGJvYXJk IHRoYXQgd2FudHMgdGhlIGtlcm5lbCB0byBvd24gdGhlIGdhdGUgY2FuCj4gPiA+IHJlZmVyZW5j ZSBJMlMqXzhDSF9NQ0xLT1VUX1RPX0lPIGZyb20gRFQgaW5zdGVhZC4KPiA+ID4KPiA+ID4gWy4u Ll0KPiA+Cj4gPiBBcHBsaWVkLCB0aGFua3MhCj4gPgo+ID4gWzEvMV0gY2xrOiByb2NrY2hpcDog cmszNTg4OiBkb24ndCBkaXNhYmxlIHVudXNlZCBJMlMgTUNMSyBvdXRwdXQgZ2F0ZXMKPiA+ICAg ICAgIGNvbW1pdDogOTQ2MzUyYjJmODhmZDIzNzhmMDM0MTMxMmU0N2RmZjFlOGRjMmZhYwo+IAo+ IEluIGhpbmRzaWdodCBtYXliZSBpdCB3b3VsZCBoYXZlIGJlZW4gYSBiZXR0ZXIgaWRlYSB0byBt YXAgdGhlIGV4aXN0aW5nCj4gY2xvY2sgSUQgSTJTKl84Q0hfTUNMS09VVCB0byB0aGUgbmV3IGdh dGVzLCBhbmQgYWRkIChvciBub3QgYWRkKSBuZXcKPiBjbG9ja3MgZm9yIHRoZSBpbnRlcm5hbCBN Q0xLIGdhdGVzLgo+IAo+IFRoZW4geW91IHdvdWxkbid0IG5lZWQgdG8gdXBkYXRlIHRoZSBEVHMs IHdvdWxkbid0IG5lZWQgdGhpcyB3b3JrYXJvdW5kLAo+IGFuZCB3b3VsZG4ndCBkZXBlbmQgb24g dGhlIGJvb3Rsb2FkZXIgdG8gc2V0IHRoZSByZWdpc3RlcnMgY29ycmVjdGx5IHdoZW4KPiBib290 aW5nIGFuIG9sZCBEVC4KCkhlbHAgbWUgdW5kZXJzdGFuZCBmb3IgdGhlIGZ1dHVyZTogSWYgdGhl IGFwcHJvYWNoIHlvdSBkZXNjcmliZSB3b3VsZApoYXZlIGJlZW4gdXNlZCwgdGhlbiB0aGUgY2xv Y2tzIGluIHRoZSBrZXJuZWwgd291bGQgaGF2ZSBiZWVuIG1pc2xhYmVsZWQKaW4gdGhlIGtlcm5l bCBkcml2ZXIgY29tcGFyZWQgdG8gd2hhdCdzIGFjdHVhbGx5IG9uIHRoZSBTb0MsIGNvcnJlY3Q/ ClRoYXQgd291bGQgaGF2ZSBiZWVuIG1vcmUgZGVzaXJhYmxlIGluIG9yZGVyIHRvIGtlZXAgY29t cGF0aWJpbGl0eSB3aXRoCnRoZSBvbGRlciBEVHM/CgpCdXQgdGhlIG9sZGVyIERUcyBjYW4gc3Rp bGwgcmVmZXJlbmNlIHRoZSBtdXgsIGNvcnJlY3Q/IEZyb20gdGhlCmtlcm5lbCdzIHBlcnNwZWN0 aXZlIGluIHRoaXMgc2NlbmFyaW8sIHRoZSBpbXBvcnRhbnQgdGhpbmcgaXMgZm9yIHRoZQptdXgg dG8gc2VsZWN0IHRoZSBhcHByb3ByaWF0ZSBwYXJlbnQuIFRoZSBlbmQgZ2F0ZSB3aWxsIGFsd2F5 cyBiZSBsZWZ0Cm9uLiBGcm9tIGEgcG93ZXIgbWFuYWdlbWVudCBwZXJzcGVjdGl2ZSwgdGhlIHBv d2VyIHdpbGwgYmUgY3V0IGZ1cnRoZXIKdXAgdGhlIGNsb2NrIHRyZWUgYXMgbmVlZGVkLgoKQnJp YW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7828BC55ABF for ; Wed, 5 Aug 2026 23:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P5KkfoazfSd7LbFAmZXs7FVBEh30eBrbBqu13ZxDK8Q=; b=kYLy+vE3duhS93efG8L5VS+T4R Lcp9WbWu26q6JTlayKhSyazq0E8L7AGPrjSoDEkntMsfqB3xY3cVfC4TB5uqoIqxWI9iGKiG72YoA mhS9d/WMo7LF04Z9xfwbEt8Qa5E/r8MKHrk11CTETyYmfaNJKEJhxDiIjRu3hsWn3Bd6mbX9WpT5b ff68dyulOTTbWbQpPYAlYa/i/kxAvY9M08szCi99fTIkFmpV2SFoJRnjgCJLU5RXr1oe1PIqTQjRd VwneyQBF0v7SI3XwC/uYmMnmspnvjmOD5i8J3d5yrIxVDC6uQys69PQ9r5qhSjEih2IiSD5weJdgG OcXIgwQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrkjv-00000004dUS-3ib0; Wed, 05 Aug 2026 23:09:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrkjs-00000004dTZ-17m6 for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2026 23:09:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785971369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P5KkfoazfSd7LbFAmZXs7FVBEh30eBrbBqu13ZxDK8Q=; b=QKszLQKHTkqU8jIZFdAWkoirZQ7m0eacUrrlGq74E2I+MMeHzDgP6V5/jMfJYg4G1n7Lhq tQP8hHwn31Ri5umuGO2V3jXDC+Zf9j09nEqUh/OouZ9EDgjUTuM9Xq0TVgc+FNgJ5IGJMI bitEZL4vTdXArxvssBNBUkSS7cxEok4= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-LeWQiChDPWWDWrGzGsT39A-1; Wed, 05 Aug 2026 19:09:27 -0400 X-MC-Unique: LeWQiChDPWWDWrGzGsT39A-1 X-Mimecast-MFC-AGG-ID: LeWQiChDPWWDWrGzGsT39A_1785971367 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-664c8e55e71so2532648d50.0 for ; Wed, 05 Aug 2026 16:09:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785971367; x=1786576167; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=P5KkfoazfSd7LbFAmZXs7FVBEh30eBrbBqu13ZxDK8Q=; b=GZ3D0dyh1Cviqj3PSiyrGf/Y4GzPgObd+Lab+xr72+gZ1i7Kg5BiFt30np9fbhGV+a H+PZ2BvEQlSXzjsD8uqDACKQ0Rr45NRVUdAD6XCwWhUrtz/WOL0M1i7LgcctptW7kVoK yM9RJSZgZDjzbaVBIOJ4cNSLZfRz4U7zWt3rfJ2It2+DXyoZ76OfftBBaPEr+NQvsguv WnIlFlAlqFKQtCKhPABBjwLBFvEMoizRsqZuIN/FGOAERbzh6OF0EL/q7YD674LsaCkv foRBx3Eq7tNk2xuLr1dKeK9iFJY8F+N7VBTuHonej8tkQ4DZBAASQD/7oyQRdIYCTqsO cn0A== X-Forwarded-Encrypted: i=1; AHgh+Rqse7g3hysCWEFgLWFdmAbPm5w89C/qvMjpIGKpOpHnLrVkqP1wuhwgcslFlnZwktYtLfBKrLUYh6rxhH6WTnIW@lists.infradead.org X-Gm-Message-State: AOJu0YwSyvSbXr4sFepUAefGA+DB8zMgUPp6MvyvRJNwx6lNxor0X7bF eXeYQVXAp5qzImDAkbR0deP2Hmf4jsQoDE6pqAvQ6k3vgDiq2iiPOVWlLzTtfQvPfwGLGSgkfYD g8eyjEdUxQRZ1I+xmiFXtlcOAVD6rp/OuF4hMAE18E5ffeUdnR8GYpyBv8jKHkDxDNqJP44KcwK nR X-Gm-Gg: AR+sD13Nh6B8R5XkHTKdfHYT9mS5gG7KVkUxX9Et8Fbpebk6cSDkRYAI1wiGbwwd1WS WICcEVS1L8Hd3NMM8irErD+xhG9q0as8l5tOrnK6v0Yf8SRxwKXeY/DKk11/cIx7JfZvWn7TJ2d sB4Tkc8d4bdMXOxq7A+hj+GdrMOijioJf0XLm+NacNHPcrqgrLnfxZLih/VLWsR8LewwVSES8+o lgh+Mn0G3vw7N0HSeojAXWcvi61y5qHQSfaXVXHMWNYFUPWmmyDCIhrGgfRambgs0RZLWg7o4Ii xOnDN2GvQrwn4k999Ltkw2PDVpHV0bjrN8fl0ENHO0/ymuFBLxV0DKQnpgrJKfPQlsrrUmjMrUa mhO7rz+fWC1WXuaLpHr99iO5/lsOaChVHp44= X-Received: by 2002:a05:690e:250b:10b0:667:a95b:59f0 with SMTP id 956f58d0204a3-6699abcfe28mr5022131d50.34.1785971366754; Wed, 05 Aug 2026 16:09:26 -0700 (PDT) X-Received: by 2002:a05:690e:250b:10b0:667:a95b:59f0 with SMTP id 956f58d0204a3-6699abcfe28mr5022102d50.34.1785971366332; Wed, 05 Aug 2026 16:09:26 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-669913b9903sm3924589d50.7.2026.08.05.16.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 16:09:25 -0700 (PDT) Date: Wed, 5 Aug 2026 19:09:23 -0400 From: Brian Masney To: Chen-Yu Tsai Cc: Heiko Stuebner , Michael Turquette , Stephen Boyd , Daniele Briguglio , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas , Nicolas Frattaroli , Ricardo Pardini Subject: Re: [PATCH] clk: rockchip: rk3588: don't disable unused I2S MCLK output gates Message-ID: References: <20260624123914.1767374-1-hello@superkali.me> <178267399833.3089434.5140309637329023610.b4-ty@sntech.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: adqhqPZn10p8Hhl6Lk6qZ03fIbUs5QAn0A1cSvMHOWI_1785971367 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260805_160932_371929_A9FD015D X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chen-Yu, On Thu, Aug 06, 2026 at 01:00:02AM +0800, Chen-Yu Tsai wrote: > On Mon, Jun 29, 2026 at 3:13 AM Heiko Stuebner wrote: > > > > > > On Wed, 24 Jun 2026 14:39:14 +0200, Daniele Briguglio wrote: > > > No in-tree board references these gates yet. Boards drive the codec > > > MCLK through the parent I2S*_8CH_MCLKOUT, and now that the gates are > > > managed clocks, clk_disable_unused() turns them off at boot. On a board > > > that relied on firmware leaving the output enabled, that cuts the MCLK > > > and analog audio stops working. > > > > > > Mark the four gates CLK_IGNORE_UNUSED so an unreferenced gate keeps the > > > state firmware left. A board that wants the kernel to own the gate can > > > reference I2S*_8CH_MCLKOUT_TO_IO from DT instead. > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] clk: rockchip: rk3588: don't disable unused I2S MCLK output gates > > commit: 946352b2f88fd2378f0341312e47dff1e8dc2fac > > In hindsight maybe it would have been a better idea to map the existing > clock ID I2S*_8CH_MCLKOUT to the new gates, and add (or not add) new > clocks for the internal MCLK gates. > > Then you wouldn't need to update the DTs, wouldn't need this workaround, > and wouldn't depend on the bootloader to set the registers correctly when > booting an old DT. Help me understand for the future: If the approach you describe would have been used, then the clocks in the kernel would have been mislabeled in the kernel driver compared to what's actually on the SoC, correct? That would have been more desirable in order to keep compatibility with the older DTs? But the older DTs can still reference the mux, correct? From the kernel's perspective in this scenario, the important thing is for the mux to select the appropriate parent. The end gate will always be left on. From a power management perspective, the power will be cut further up the clock tree as needed. Brian