All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Subject: Re: [PATCH nf] netfilter: ipset: let destroy callbacks adjust ext mem size
Date: Thu, 6 Aug 2026 18:52:05 +0200	[thread overview]
Message-ID: <anS7tUXBHWztzD9m@strlen.de> (raw)
In-Reply-To: <20260806141750.10441-1-fw@strlen.de>

Florian Westphal <fw@strlen.de> wrote:
> For bitmap this change makes no difference, because destructors are
> called synchronously.
> List type however calls them via call_rcu() so accounting decrement can
> happen after list_set_flush() set ext_size to 0.
> 
> 'set->elements = 0' can be removed for the same reason in the list type
> case, it calls 'set->elements--' for each element.
> 
> Fixes: 9e41f26a505c ("netfilter: ipset: Count non-static extension memory for userspace")
> Suggested-by: Jozsef Kadlecsik <kadlec@netfilter.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
>  sashiko: list_set_uadd() may call list_set_replace() and
>  then erronously increments set->elements, causing a counter
>  drift. This bug will be resolved in a different patch.

Seems sashiko ignored this and reported this bug again.
The report can thus be discarded.

  reply	other threads:[~2026-08-06 16:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 14:17 [PATCH nf] netfilter: ipset: let destroy callbacks adjust ext mem size Florian Westphal
2026-08-06 16:52 ` Florian Westphal [this message]
2026-08-09 12:59 ` Jozsef Kadlecsik
  -- strict thread matches above, loose matches on Subject: below --
2026-08-04 17:02 Florian Westphal
2026-08-09 11:20 ` Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anS7tUXBHWztzD9m@strlen.de \
    --to=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.