From: Niklas Cassel <cassel@kernel.org>
To: Sam Li <faithilikerun@gmail.com>, dlemoal@kernel.org
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v14 3/6] qcow2: add configurations for zoned format extension
Date: Fri, 7 Aug 2026 02:06:47 +0200 [thread overview]
Message-ID: <anUhlwOBFW_lUThL@ryzen> (raw)
In-Reply-To: <anUfL40CLw_amIJE@ryzen>
On Fri, Aug 07, 2026 at 01:56:36AM +0200, Niklas Cassel wrote:
> Looking at the write_granularity in virtio-blk + file-posix:
> for blkcfg.zoned.write_granularity, which is what virtio-blk exposes to
> the guest, it is initialized using:
> https://github.com/qemu/qemu/blob/v11.1.0-rc3/hw/block/virtio-blk.c#L1257
> conf->logical_block_size:
> https://github.com/qemu/qemu/blob/v11.1.0-rc3/hw/block/virtio-blk.c#L1183
>
> and the value we set to the qemu block layer - bs->bl.write_granularity,
> which file-posix initilizes using:
> https://github.com/qemu/qemu/blob/v11.1.0-rc3/block/file-posix.c#L1498-L1501
> the sysfs value for physical_block_size.
If we are using sysfs, I wonder why this code does not simply read:
/sys/block/<disk>/queue/zone_write_granularity
instead.
But that would still be inconsistent with blkcfg.zoned.write_granularity which
is initialized using conf->logical_block_size.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-08-07 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 22:16 [PATCH v14 0/6] Add full zoned storage emulation to the qcow2 driver Sam Li
2026-07-08 22:16 ` [PATCH v14 1/6] docs/qcow2: add the zoned format feature Sam Li
2026-07-08 22:16 ` [PATCH v14 2/6] block: widen BlockLimits.zone_size to uint64_t Sam Li
2026-07-08 22:16 ` [PATCH v14 3/6] qcow2: add configurations for zoned format extension Sam Li
2026-08-06 23:56 ` Niklas Cassel
2026-08-07 0:06 ` Niklas Cassel [this message]
2026-08-07 0:17 ` Niklas Cassel
2026-07-08 22:16 ` [PATCH v14 4/6] virtio-blk: do not merge writes across a zone boundary Sam Li
2026-07-08 22:16 ` [PATCH v14 5/6] qcow2: add zoned emulation capability Sam Li
2026-07-08 22:16 ` [PATCH v14 6/6] iotests: test the zoned format feature for qcow2 file Sam Li
2026-08-07 11:31 ` [PATCH v14 0/6] Add full zoned storage emulation to the qcow2 driver Niklas Cassel
2026-08-07 11:44 ` Sam Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anUhlwOBFW_lUThL@ryzen \
--to=cassel@kernel.org \
--cc=armbru@redhat.com \
--cc=dlemoal@kernel.org \
--cc=eblake@redhat.com \
--cc=faithilikerun@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.