From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7FB255F52 for ; Fri, 7 Aug 2026 00:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786064207; cv=none; b=KP2jAYEGAneF8zfxnIfqBdn1Hc6OFj0Pq4d6utabkeOyp0yGMDLpIfg7mEd4w1cWUSXNAW2WdjZf8ByCM25Aa6UdQOFjDK7pNZByViKPLimh8RmC6f4KCYk9Ql/iNLtpXk8XkeieHvRsDc5Rt7Fu2a37kVLN2aGKN3oIgAy+mSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786064207; c=relaxed/simple; bh=xaqEawUcKzqcXHKZwNsMONvFjoxesrE/pbHOtm3vIQI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XfzxCKdR3G2OcPiGi1wnZB3KzL2xfYZEMNXCA/j/dYa8Hpc50Ih6FhDAOdeGuOWvXVtRheGmS51a5KVGLnV4aWxJiZzH1/josmnu7BpbOFS1kOX8QshFo4inKhWBa0ZBmv8TWJLLa7OGeoNFeifRWaD1BWHfESaEmKEZvJoqQBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kZXWgwhp; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kZXWgwhp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786064204; x=1817600204; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xaqEawUcKzqcXHKZwNsMONvFjoxesrE/pbHOtm3vIQI=; b=kZXWgwhpOLWvaPZevVnXJxtd68GdMghZrjlwNx9crjTrpG354+PgQ4Al Z72SU+DOAy1K+56gCEdUR3ZiJgQ4VrtQgLG4Ezo/eT15P+fqhCGc94GCf drG0XX3GGZBVjeCZysCV9LxgrShDBh05nTVCHp3AOLAmNOZ4ueyeeLQYq vwOQIghDIwKIzvMsKGX/utVkUVgY472LLBC6c0iKhUFn4qdSxFuJI5bRq 8J0F6gLNO7J4UATftliPvBy6j/07f6n4Ywq0rEjoXH6ndILTyN20mQ69e hcDA58kkn7tXxHHu6/1U4CT8YOasRQCibUUupB9QfgwD0//0NSNxQaPAf w==; X-CSE-ConnectionGUID: lpO3DI2HQk27NySxdTE0FA== X-CSE-MsgGUID: aFakHKTKTc6NZwseOXR1vg== X-IronPort-AV: E=McAfee;i="6800,10657,11867"; a="104204176" X-IronPort-AV: E=Sophos;i="6.25,209,1779174000"; d="scan'208";a="104204176" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2026 17:56:43 -0700 X-CSE-ConnectionGUID: 5WDPTH/PQKq7JVutMVnZiQ== X-CSE-MsgGUID: GAiCsshUS6uEexCdJ2ouSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,209,1779174000"; d="scan'208";a="262316399" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.50]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2026 17:56:41 -0700 Date: Fri, 7 Aug 2026 03:56:38 +0300 From: Andy Shevchenko To: Anshuman Khandual Cc: Matthew Wilcox , "David Hildenbrand (Arm)" , linux-mm@kvack.org, usama.arif@linux.dev, hughd@google.com, ryan.roberts@arm.com, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] mm: Standardize printing for pgtable entries Message-ID: References: <20260709044334.1741263-1-anshuman.khandual@arm.com> <5ee8783e-4deb-48fc-a4c4-96b02d79a6cb@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jul 27, 2026 at 06:20:39PM +0530, Anshuman Khandual wrote: > On 13/07/26 9:36 PM, Andy Shevchenko wrote: > > On Mon, Jul 13, 2026 at 01:34:17PM +0100, Matthew Wilcox wrote: > >> On Mon, Jul 13, 2026 at 02:36:50PM +0300, Andy Shevchenko wrote: ... > >>> FWIW, we have hex_dump_to_buffer() for that already. > >> ... which doesn't eliminate the problem of allocating buffers in the > >> caller. > > > > Right, for this we need to integrate hex_dump_to_buffer() into %ph. > > Would not that create more complexity which might not really > be required here for simple pgtable entry print solution that > would probably have very limited number of callers anyway. Is > not that reason - we did not go for the original printk format > proposed earlier. > > https://lore.kernel.org/all/20260610043545.3725735-1-anshuman.khandual@arm.com/ > > IMHO this should be left unchanged. Later if there are more > users for such prints, those printk formats should again be > evaluated. My comment was only to show the possible option to solve what Matthew pointed out without relation to any exact usage. Yes, for this certain change this might be an overkill. -- With Best Regards, Andy Shevchenko