Re: [Buildroot] [PATCH 1/2] package/uglifyjs: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: buildroot@buildroot.org,
	 Nicolas Carrier <nicolas.carrier@nav-timing.safrangroup.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/uglifyjs: new package
Date: Fri, 7 Aug 2026 09:44:17 +0200	[thread overview]
Message-ID: <anWMFshKM90_1I-z@windsurf> (raw)
In-Reply-To: <20260806-host_tools-v1-1-19c63ecc3b10@bootlin.com>

Hello Alexis,

On Thu, Aug 06, 2026 at 11:24:22PM +0200, Alexis Lothoré wrote:
> uglifyjs is a JavaScript parser, minifier, compressor and beautifier
> toolkit.
> 
> https://github.com/mishoo/UglifyJS
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Thanks for the patch. Overall looks good. One or two suggestions below.

> new file mode 100644
> index 000000000000..921d4dffee8e
> --- /dev/null
> +++ b/package/uglifyjs/uglifyjs.mk
> @@ -0,0 +1,23 @@
> +################################################################################
> +#
> +# uglifyjs
> +#
> +################################################################################
> +
> +UGLIFYJS_VERSION = 3.19.3
> +UGLIFYJS_SITE = $(call github,mishoo,UglifyJS,v$(UGLIFYJS_VERSION))
> +UGLIFYJS_LICENSE = BSD-2-Clause
> +UGLIFYJS_LICENSE_FILES = LICENSE
> +HOST_UGLIFYJS_DEPENDENCIES = host-nodejs
> +
> +define HOST_UGLIFYJS_INSTALL_CMDS
> +	$(INSTALL) -m 0755 -d $(HOST_DIR)/lib/node_modules/uglify-js
> +	rsync -a $(@D)/bin $(HOST_DIR)/lib/node_modules/uglify-js/
> +	rsync -a $(@D)/lib $(HOST_DIR)/lib/node_modules/uglify-js/
> +	rsync -a $(@D)/tools $(HOST_DIR)/lib/node_modules/uglify-js/

We more commonly use "cp -dpfr" for this kind of situation, and you
could also use a loop?

> +	$(INSTALL) -m 0755 $(@D)/package.json $(HOST_DIR)/lib/node_modules/uglify-js/

Something like:

	$(foreach p,bin lib tools package.json,\
		cp -dpfr $(@D)/$(p) $(HOST_DIR)/lib/node_modules/uglify-js/
	)

> +	ln -sf ../lib/node_modules/uglify-js/bin/uglifyjs $(HOST_DIR)/bin/uglifyjs
> +

Drop this empty new line.

> +endef
> +
> +$(eval $(host-generic-package))
> diff --git a/support/testing/tests/package/test_uglifyjs.py b/support/testing/tests/package/test_uglifyjs.py
> new file mode 100644
> index 000000000000..666a5fb46ff1
> --- /dev/null
> +++ b/support/testing/tests/package/test_uglifyjs.py

Forgot about commenting on this on the DEVELOPERS file: please add
this file to the DEVELOPERS file as well, under your name. This way if
this test fails in our CI, you'll get notified.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot