From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function
Date: Fri, 7 Aug 2026 19:39:47 +0300 [thread overview]
Message-ID: <anYKU1f7kjGrZusA@archlinux> (raw)
In-Reply-To: <2026080749-dolly-never-0406@gregkh>
On Fri, Aug 07, 2026 at 09:03:21AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote:
> > The return value of this function is ignored at the call site, and since
> > the function has no side effects (except for the assignment to
> > pHalData->pwrdown, which is not used anywhere else), it can be removed.
> >
> > At the same time, remove the efuse shadow functions, as they are
> > becoming unused.
>
> Why not remove pwrdown first, which shows that it is never actually
> used, and then remove the functions in a separate patch? that would
> "prove" that this is a safe change, as-is we need to manually verify
> this patch is correct.
Yes, that really would be better. I will do that in v2.
next prev parent reply other threads:[~2026-08-07 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 19:34 [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Nikolay Kulikov
2026-08-07 7:03 ` Greg Kroah-Hartman
2026-08-07 16:39 ` Nikolay Kulikov [this message]
2026-08-07 7:53 ` Dan Carpenter
2026-08-07 16:41 ` Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anYKU1f7kjGrZusA@archlinux \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.