From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8023B395D8C for ; Fri, 7 Aug 2026 17:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786122075; cv=none; b=XkN/Hd3IKJvmDTeZSaopQsMROcDTL75+034dp6+2esEyKpKV0pLRF+GbkTgU0Ke83a1xgKbLnQ/fvG0bEw7LTp8H0eVoJKtS7Fe4VHoIEBFeeeDf3UBfCkXaNxuzBGDGnLy1eHgWrFZoUk89V9QdkP3qhI1JYoRykZVHBp60AYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786122075; c=relaxed/simple; bh=RSIdKRtdZo5igr1HPXhz2hV8SMag4nqOf0t+4Fk1ukM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GLK0BzlLvlzDAo/wGpFgIMPvcmJzZXPN4CNR5Y3vJS6uZi9Y9dVaORPFFrub2ruYsPNjjuKTwu6A8KLIXOgcoMoxaoDMZPOfrSOSDtHn7260FHxyk1qJ0UlbaV17/JeDs1CmBjjqDIddvvQhZZq+KStD1V8P2xJ22KbZSQ6gHVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=uU9vE60F; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="uU9vE60F" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-908a2ca5becso8039746d6.0 for ; Fri, 07 Aug 2026 10:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1786122071; x=1786726871; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=02i1ooJbKuCBAzogAwLi+8I9El04yi+39Um7MRS4spQ=; b=uU9vE60FcsjnMfJ1TeDldvjuzf1JIPZpRAQ8MXsvf/pR4tmw/IUdUo5zrBeXwPF0u2 IovZxowUsjAfW59VOlT84V0GeHf5EGWjQn8IfEFCwtT2NHOSudAHKSwkt/Ko6drkW1Oa cyWo/2vZ8e9U0aMiLFjnxvQq0mWYEGr4fRkRKe7N5amgzpLahdNF+Y8phtiVvFXzRpk6 Ppi2o0FXm2HsD+Lf+nECP1Jtcxxo+b/zrjFWO3W2BVYG+zkI6hmGYzlKQdcqtc+f3Tzz pdO90aCRxdgd1gSiwGrfL+5q8FqoAlkVMGiprdn/tGEOlbnOIQNWw7dRg8LxRkvLoS/u 69aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786122071; x=1786726871; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=02i1ooJbKuCBAzogAwLi+8I9El04yi+39Um7MRS4spQ=; b=nXaqbVwjKH9Fb67dlTRDCOlf83GDmHWWxpyzPqf/VBr4y4mrU3GKoNid8IxvVcccYi yMWv5VPMzgrjV+J9jRZECQ/atHUpUnC5CDOzQxS7kxk63xGC9PUtojL9d+SJ5CS3QMei TOWhQOIoiTF4Q6jZK6POiRVFoGwJEo8BA5+NKxoumriRqa/+o/Av6CAaQKhwzjg8OD9r 8vrD2JyN88Ix75J6XZ9Fw7YS+FJpooUMMXfXko1m91IrfpwqU13vo1eRVu5Ri1e6E4mO 9KOWWfO370HjaeLpD6MDaQWpnSmo9VSan8qK5zWq0eQvbNPomBX3uc+l9wF0suIS06K1 bqmg== X-Forwarded-Encrypted: i=1; AHgh+RqHR/R81dxllio8mtde/E/+j4yU6s5TckUyMHlAdHk5/UB5N2DUW3yCbsKBE3IEQu2cejWZdbyAO3fczS4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd/YDYRj+mRLxAQUX5+81eLfqqWOK/Pj+nCKq9TPdmM/TTSAyG tIL6iKB6uA2VcX/F9C4+cXEuVjJ12IcHEJRyw+4Dk2AUynPRHXizSMtRcsMkXsGmbkXdU5YLMcT saRKU X-Gm-Gg: AR+sD11Um133t981c3KRCMOvnFRDrKbupL2mfHB3vSqf7gPw13Pc7aceQdCsQBMlpqh tNXZ79RLxTWDqYZt6AuHkUYTftCuTS2/VYCni9y/k/2JeD0HEpz7Mv6dutHfUTxq3Qm3yk2O7vd 0mEsFtRjvQzI7iJAuJFVYsQV92xUvfC2r42XuDhV3YuboZKY36Hrs6XlTyYCYhJZ7EHbBiVOhfJ xZMeoSa1cUAYoBUWBLyndQ7KiuKRkYHcHHftJkDFbm8jBztAiuHYQOZa9zj3CyoLAR+RWSfRMet ubs0DzfYq26ZH7WvK3WzIwkzk+J6FWdEwRt6m0qho2VZgjCyhE8V3cz7aX+zQIW6/90BxJBLUx4 TMGPcJPfHEoLvdF2tf+/y9JNJQs10vSUn17WDk1cWM1c6fdpQKDbejkYnSGFAoQ+qjkDK/Ltaku 92li72SJDg85aB74v5HCe00qZUz8ohMv7KNV3xHXBaxKCSxF6EQDPLgmk80UNP X-Received: by 2002:a05:6214:3c9a:b0:908:93ff:cba9 with SMTP id 6a1803df08f44-9089c06929fmr140577346d6.32.1786122071119; Fri, 07 Aug 2026 10:01:11 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908a91b4a6csm12874506d6.15.2026.08.07.10.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 10:01:09 -0700 (PDT) Date: Fri, 7 Aug 2026 13:01:08 -0400 From: Johannes Weiner To: Tal Zussman Cc: Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Matthew Wilcox , Christoph Hellwig , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] mm/swap: rename __swap_writepage() to __swap_writeout() Message-ID: References: <20260806-b4-page_io-folios-v1-0-0899bac3b826@columbia.edu> <20260806-b4-page_io-folios-v1-6-0899bac3b826@columbia.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806-b4-page_io-folios-v1-6-0899bac3b826@columbia.edu> On Thu, Aug 06, 2026 at 06:55:38PM -0400, Tal Zussman wrote: > Commit 84798514db50 ("mm: Remove swap_writepage() and > shmem_writepage()") renamed swap_writepage() to swap_writeout(). Rename > __swap_writepage(), which operates on a folio, to match its caller. > Update a stale reference to swap_writepage() in swapfile.c as well. > > Signed-off-by: Tal Zussman Looking at that commit, I can only guess that pageout() had an influence on the swap_writeout() name. However, on the read side of the page_io.c API, we're following swap_read_folio* consistently. [__]swap_write_folio* would seem more symmetrical? [ At the risk of starting something, should the file itself be renamed? swap_rw.c or swap_io.c or something. ]