From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Rob Herring <robh@kernel.org>
Cc: sashiko-reviews@lists.linux.dev, conor+dt@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v11 20/21] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells
Date: Fri, 7 Aug 2026 19:58:43 +0200 [thread overview]
Message-ID: <anYanfuZQT4Pz6lC@venus> (raw)
In-Reply-To: <20260807155140.GA882294-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2722 bytes --]
Hello Rob,
On Fri, Aug 07, 2026 at 10:51:40AM -0500, Rob Herring wrote:
> On Thu, Aug 06, 2026 at 05:39:59PM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Medium] Device Tree schema validation breakage for existing `rockchip,rk3588-dp` configurations.
> > --
> >
> > --- Patch [20]: [PATCH v11 20/21] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells ---
> > commit 2c15bbfcf4dec184872abdf4c2e06063a52d1e2f
> > Author: Sebastian Reichel <sebastian.reichel@collabora.com>
> >
> > dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells
> >
> > The RK3588 and RK3576 DesignWare DisplayPort controllers both have two
> > possible DAI interfaces: I2S and S/PDIF. Thus an argument is needed to
> > to select the right interface.
> >
> > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> > > index 2b0d9e23e9432..c4f8959dd65da 100644
> > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> > [ ... ]
> > > @@ -83,7 +83,8 @@ properties:
> > > maxItems: 1
> > >
> > > "#sound-dai-cells":
> > > - const: 0
> > > + const: 1
> > > + description: 0 for I2S, 1 for S/PDIF
> >
> > [Severity: Medium]
> > Will this strict constraint update cause make dtbs_check validation to
> > fail for existing in-tree device trees?
> >
> > The mainline arch/arm64/boot/dts/rockchip/rk3588-base.dtsi still defines
> > #sound-dai-cells = <0>; for DP nodes.
> >
> > While the commit message notes this breakage is intentional and will be
> > fixed up separately, could changing the schema without the accompanying
> > DTS updates cause automated CI validation failures and break bisectability?
>
> Yes, and I don't love the intermittent warnings introduced. As long as
> the warnings are on a downward trajectory, I won't notice...
>
> Not saying you have to do something here, but this will get more
> strict...
I don't like it either, but it's the best I came up with. If DT is
updated first, there will be a warning for the DAI cells being 1
instead of 0. To fully avoid the warning I see these options:
1. update DT binding and DTS in a single patch
2. allow 0 and 1 in the binding with 0 not really working
IMHO neither of those are great either, so I ended up with the
series like this. Regarding the downward trajectory: RK3588 should
be completley free of warnings in dtbs_check at the moment.
Greetings,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-08-07 17:59 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 17:02 [PATCH v11 00/21] Synopsys DisplayPort Controller improvements for Rockchip platforms Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 01/21] drm/bridge: synopsys: dw-dp: Register DP AUX on bridge attach Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:37 ` sashiko-bot
2026-08-16 12:37 ` Andy Yan
2026-08-16 12:37 ` Andy Yan
2026-08-17 16:19 ` [PATCH " Sebastian Reichel
2026-08-17 16:19 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 02/21] drm/bridge: synopsys: dw-dp: Fix incorrect resource lifetimes in bind callback Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:36 ` sashiko-bot
2026-08-16 12:41 ` Andy Yan
2026-08-16 12:41 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 03/21] drm/bridge: synopsys: dw-dp: Fix error handling for DP link enablement Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:29 ` sashiko-bot
2026-08-16 12:44 ` Andy Yan
2026-08-16 12:44 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 04/21] drm/bridge: synopsys: dw-dp: Document missing reset line deassert Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:33 ` sashiko-bot
2026-08-16 12:47 ` Andy Yan
2026-08-16 12:47 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 05/21] drm/bridge: synopsys: dw-dp: Add missing mutex cleanups on module removal Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:30 ` sashiko-bot
2026-08-16 12:49 ` Andy Yan
2026-08-16 12:49 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 06/21] drm/bridge: synopsys: dw-dp: Fix AUX transfer timeout race condition Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:32 ` sashiko-bot
2026-08-16 12:52 ` Andy Yan
2026-08-16 12:52 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 07/21] drm/bridge: synopsys: dw-dp: Fix support for short I2C reads Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-16 12:54 ` Andy Yan
2026-08-16 12:54 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 08/21] drm/bridge: synopsys: dw-dp: Free output_fmts when none are valid Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-16 12:56 ` Andy Yan
2026-08-16 12:56 ` Andy Yan
2026-08-06 17:02 ` [PATCH v11 09/21] drm/bridge: synopsys: dw-dp: Support MEDIA_BUS_FMT_FIXED Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:33 ` sashiko-bot
2026-08-06 17:02 ` [PATCH v11 10/21] drm/bridge: synopsys: dw-dp: Add follow-up bridge support Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-07 2:50 ` Chaoyi Chen
2026-08-07 2:50 ` Chaoyi Chen
2026-08-06 17:02 ` [PATCH v11 11/21] drm/bridge: Add out-of-band HPD notify handler Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 12/21] drm/bridge: synopsys: dw-dp: Support software triggered OOB HPD Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 13/21] drm/rockchip: dw_dp: Implement out-of-band HPD handling Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:27 ` sashiko-bot
2026-08-06 17:02 ` [PATCH v11 14/21] drm/bridge: synopsys: dw-dp: Add Runtime PM support Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:41 ` sashiko-bot
2026-08-06 17:02 ` [PATCH v11 15/21] drm/rockchip: dw_dp: Add runtime " Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:45 ` sashiko-bot
2026-08-06 17:02 ` [PATCH v11 16/21] drm/bridge: synopsys: dw-dp: Protect sdp_reg_bank from concurrent access Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 17/21] drm/bridge: synopsys: dw-dp: Drop useless reservation of first slot Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:45 ` sashiko-bot
2026-08-06 17:02 ` [PATCH v11 18/21] drm/bridge: synopsys: dw-dp: Clear only enabled SDPs on atomic disable Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 19/21] drm/bridge: synopsys: dw-dp: Use regmap_set_bits in dw_dp_send_sdp Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:02 ` [PATCH v11 20/21] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:39 ` sashiko-bot
2026-08-07 15:51 ` Rob Herring
2026-08-07 17:58 ` Sebastian Reichel [this message]
2026-08-06 17:02 ` [PATCH v11 21/21] drm/bridge: synopsys: dw-dp: Add audio support Sebastian Reichel
2026-08-06 17:02 ` Sebastian Reichel
2026-08-06 17:44 ` sashiko-bot
2026-08-08 9:41 ` [PATCH v11 00/21] Synopsys DisplayPort Controller improvements for Rockchip platforms Igor Paunovic
2026-08-08 9:41 ` Igor Paunovic
2026-08-08 20:19 ` Sebastian Reichel
2026-08-08 20:19 ` Sebastian Reichel
2026-08-10 11:48 ` Heiko Stübner
2026-08-10 11:48 ` Heiko Stübner
2026-08-10 12:08 ` Alexey Charkov
2026-08-10 12:08 ` Alexey Charkov
2026-08-11 21:15 ` Igor Paunovic
2026-08-11 21:15 ` Igor Paunovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anYanfuZQT4Pz6lC@venus \
--to=sebastian.reichel@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.