From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7B53A5E64 for ; Fri, 7 Aug 2026 22:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786140078; cv=none; b=sH/WWNQQcZx1QkGhAtycZsOHnLqJVL9EUG4XTrTCQs5Bnul8JUBlH8x7r7YbOBx6ivaHOspC1bXfHf9pTaYJXfRPnQz91K6aQpQn3eSiTBNZ+BrMIwcPtBc19mI9GOUJGLVQMtCcUO9IN0wq6LWAUMU6SZD++gIJvjTM4Em/vxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786140078; c=relaxed/simple; bh=IZ9vhCR0l9NidQzu9gCgavPZJCEQ3rp9PHnpJ3sRuRA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jimjY8EWSecfZ3BMsYu93ZD784bMlTjLnCPBLAn6kjyOLpVJZUNJErlocdRiXm3UM2Vz1wX1gqH7KbcNtfejbdfPLlKR5rZ2K04TWpl6wx/rN9BaT99q7HJAWmeJca6eZpwsU8lEcQkRwFdeQVQ7SWuPpZbSQ4fs8grjol4ytBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=AArNvhku; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AArNvhku" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SIvIwzkqmZhuegbtm5Nq+eVaw1LjimqMZHDkKzPKrJY=; b=AArNvhkuNQ6BtLLzEpEqmk9isg K1aOpr64+HpKUDqgQ7Ba0T3G+e5fGIsJkNl9E57wMi6OodQnOP6IGMep8uZl8X4oyTQlBOxLvRVM7 ruush9ENJSVvpGRibHuLUYGEHyaxb0BaOenh1rQk0ESgqG978bhKDHMTECuEzfn8oUR1NVl07KA0Z vgYSKxlkLqAx9aAiLfIBHKq7QafX2BxXXWHu9kxcfpN5cVx5UxEgRXatsV4ivVwk6eU6V/OrfE0lW zijJoY8pus3azxb+5HR/GSCInWd8PI93iP3hrC8Ay0yDhxu+n3jXp+pdjWutyL9y+2GZ3QlTZfVjP XKXnuMog==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsPWd-0000000DGXR-2Os8; Fri, 07 Aug 2026 18:42:35 +0000 Date: Fri, 7 Aug 2026 19:42:35 +0100 From: Matthew Wilcox To: Johannes Weiner Cc: Tal Zussman , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Christoph Hellwig , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm/page_io: convert write completion handlers to folios Message-ID: References: <20260806-b4-page_io-folios-v1-0-0899bac3b826@columbia.edu> <20260806-b4-page_io-folios-v1-1-0899bac3b826@columbia.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 07, 2026 at 12:49:49PM -0400, Johannes Weiner wrote: > On Thu, Aug 06, 2026 at 06:55:33PM -0400, Tal Zussman wrote: > > Convert swap_write_end() and swap_fs_write_complete() to operate on > > folios directly instead of going through the folio-compat page APIs. > > This removes calls to end_page_writeback() and set_page_dirty(), and the > > last caller of ClearPageReclaim(), saving two calls to compound_head() > > per folio on the write error path. > > > > Signed-off-by: Tal Zussman > > Also the last end_page_writeback() user in mm/ :) Nice. And some uses of bv_page ;-) This is just good stuff all around. Reviewed-by: Matthew Wilcox (Oracle)