All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Danil Sirin <danilsirin24@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: mma8452: add ACPI match table
Date: Sat, 8 Aug 2026 23:33:39 +0300	[thread overview]
Message-ID: <aneSo9VObeSt3PD_@ashevche-desk.local> (raw)
In-Reply-To: <20260807171326.1137-1-danilsirin24@gmail.com>

On Fri, Aug 07, 2026 at 08:13:25PM +0300, Danil Sirin wrote:
> The mma8452 driver supports obtaining chip-specific data through
> i2c_get_match_data(), but only provides Device Tree and I2C match
> tables.
> 
> On ACPI-based x86 systems, compatible devices such as the MMA8653 are
> enumerated via ACPI, preventing the driver from binding.
> 
> Add an ACPI match table mapping the supported devices to the existing
> chip information structures.
> 
> Tested on a Bay Trail tablet exposing an MMA8653 device via ACPI. With
> this change the driver successfully probes, reads the expected chip ID
> (0x5a), and registers an IIO device.

...


Jonathan beat me up to it, so follow exactly what he said, we do not accept
fake ACPI IDs, they must be properly registered. Yet, for the broken ones in
the wild (device is on market), we need to have a shameful comment and a note
to the vendor of the firmware (BIOS) to explain them that they are wrong.

Also check the MS catalog for the ID if it appears in the Windows drivers.
This information also has to be added to the commit message.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-08-08 20:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 13:51 [PATCH] iio: accel: mma8452: add ACPI match table veeenjoyer24
2026-08-07 14:59 ` Joshua Crofts
2026-08-07 17:13   ` [PATCH v2] " Danil Sirin
2026-08-07 23:28     ` Jonathan Cameron
2026-08-08 20:33     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aneSo9VObeSt3PD_@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=danilsirin24@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.