From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, u.kleine-koenig@baylibre.com, dakr@kernel.org,
bhelgaas@google.com, mazziesaccount@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning
Date: Sat, 8 Aug 2026 23:56:57 +0300 [thread overview]
Message-ID: <aneYGVo4gbbbYqFK@ashevche-desk.local> (raw)
In-Reply-To: <20260802012329.9877-1-adinata.softwareengineer@gmail.com>
On Sun, Aug 02, 2026 at 09:23:26AM +0800, Adi Nata wrote:
> Checkpatch warning:
>
> WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
>
> WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> +static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,
> static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(htu21_show_samp_freq);
> -static IIO_DEVICE_ATTR(battery_low, S_IRUGO,
> +static IIO_DEVICE_ATTR(battery_low, 0444,
> htu21_show_battery_low, NULL, 0);
> -static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(heater_enable, 0644,
> htu21_show_heater, htu21_write_heater, 0);
What's wrong with IIO_DEVICE_ATTR_RW()?
Same comment to all patches of a kind from you.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-08 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 1:23 [PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning Adi Nata
2026-08-02 12:38 ` Uwe Kleine-König
2026-08-02 16:56 ` Jonathan Cameron
2026-08-08 20:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aneYGVo4gbbbYqFK@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.