Re: [Buildroot] [PATCH v2] package/libxmlsec1: bump version to 1.3.12

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>,
	 Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH v2] package/libxmlsec1: bump version to 1.3.12
Date: Sun, 9 Aug 2026 12:41:58 +0200	[thread overview]
Message-ID: <anhY2jHfrtuxplGy@windsurf> (raw)
In-Reply-To: <20260803-libxmslxec-bump-v2-1-7b668ecb24e8@bootlin.com>

Hello Alexis, Hello Julien,

On Mon, Aug 03, 2026 at 04:16:46PM +0200, Alexis Lothoré via buildroot wrote:
> Update libxmlsec from 1.3.9 to 1.3.12. The package then needs a few
> adjustments:
> - there are undefined references to xmlDebugDumpDocument ([1]):
> 
>   unit_tests/transform_helpers_unit_tests.c:291:9: error: implicit
>   declaration of function ‘xmlDebugDumpDocument’
>   [-Wimplicit-function-declaration]
> 
> This is due to xmlsec1 unit tests being built systematically, and
> depending on libxml2 being built with --with-debug, so patch
> apps/Makefile.am accordingly at build time to disable unit tests build.
> 
> - the build can fail with older GCC versions due to an unimplemented
>   parameter ([2]):
> 
>   aarch64-linux-gcc.br_real: error: unrecognized command line option \
>   ‘-Wformat-overflow=2’; did you mean ‘-Wstrict-overflow=’?
> 
> This format-overflow parameter has been implemented in GCC 7, so make
> the package depend on GCC >= 7. Another solution could have been to
> pass --disable-pedantic to the package's configure, but that sounds a
> bit strong just to disable a parameter that has been exisiting for
> almost 10 years.

FYI, I don't think the solutions brought to those two problems are
really the good solutions. The problems should be fixed at the root
upstream rather than worked around.

So for the first problem: improve configure.ac to detect if libxml2
was built with debug support or not, and build unit tests or not
accordingly.

For the second problem: test the GCC flags in configure.ac before
using them.

So I went ahead and implemented those improvements, and proposed them
upstream:

  https://github.com/lsh123/xmlsec/pull/1219

We will seen upstream's feedback.

But overall I feel like Buildroot's policy should be to more into this
direction (fixing issues upstream that papering over the problem in
Buildroot).

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot