From: Florian Westphal <fw@strlen.de>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf 1/7] netfilter: ipset: remove need to allocate memory on delete operations
Date: Sun, 9 Aug 2026 16:14:16 +0200 [thread overview]
Message-ID: <aniLOIEhZS19xOuG@strlen.de> (raw)
In-Reply-To: <d65061dc-1142-de3f-349d-c77647d5e15e@netfilter.org>
Jozsef Kadlecsik <kadlec@netfilter.org> wrote:
> Sigh. It's getting more and more complicated to maintain a fairly simple
> data structure.
Yup. Would be very simple for SMP=n :-)
> What do you think which is better for the test (match) case (not
> add/del), performance-wise:
>
> - seqcount and retry
> - holes left [and INIT_CIDR() converted to a function to skip the holes
> and find the first entry for add/del]
Depends on how likely a constant pingpong between 1 / 0 count is. Given
data (packet) path can't insert a new netmask, I would guess its very
very unlikely, so the seqcount / retry loop is not used at all.
next prev parent reply other threads:[~2026-08-09 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 10:19 [PATCH nf 0/7] netfilter: switch ipset to rhashtable Florian Westphal
2026-08-06 10:19 ` [PATCH nf 1/7] netfilter: ipset: remove need to allocate memory on delete operations Florian Westphal
2026-08-09 12:56 ` Jozsef Kadlecsik
2026-08-09 14:14 ` Florian Westphal [this message]
2026-08-06 10:19 ` [PATCH nf 2/7] netfilter: ipset: let destroy callbacks adjust ext mem size Florian Westphal
2026-08-06 10:19 ` [PATCH nf 3/7] netfilter: ipset: add rhashtable boilerplate stubs Florian Westphal
2026-08-06 10:19 ` [PATCH nf 4/7] netfilter: ipset: add rhltable " Florian Westphal
2026-08-06 10:19 ` [PATCH nf 5/7] netfilter: ipset: replace internal hash table with rhashtable Florian Westphal
2026-08-06 10:19 ` [PATCH nf 6/7] netfilter: ipset: re-add forceadd support for rhashtable Florian Westphal
2026-08-06 10:19 ` [PATCH nf 7/7] netfilter: ipset: also report mem size for cidr storage to userspace Florian Westphal
2026-08-06 15:22 ` [syzbot ci] Re: netfilter: switch ipset to rhashtable syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aniLOIEhZS19xOuG@strlen.de \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.