From: Florian Westphal <fw@strlen.de>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: ipset: fix list type element drift bug
Date: Sun, 9 Aug 2026 16:16:32 +0200 [thread overview]
Message-ID: <aniLwNENxpoK-qK2@strlen.de> (raw)
In-Reply-To: <6082ea3a-15d3-650a-98a0-403b1bab7b5d@netfilter.org>
Jozsef Kadlecsik <kadlec@netfilter.org> wrote:
> Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Thanks for reviewing!
> > + if (n) {
> > list_set_replace(set, e, n);
> > + return 0;
> > + }
> > +
> > else if (next)
> > list_add_tail_rcu(&e->list, &next->list);
While it makes no difference from correctness, the
above looks very weird, so I propose to turn the else if into plain if (next).
(Did not spot it before sending...).
next prev parent reply other threads:[~2026-08-09 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 13:53 [PATCH nf] netfilter: ipset: fix list type element drift bug Florian Westphal
2026-08-06 16:51 ` Florian Westphal
2026-08-09 13:23 ` Jozsef Kadlecsik
2026-08-09 12:58 ` Jozsef Kadlecsik
2026-08-09 14:16 ` Florian Westphal [this message]
2026-08-10 13:04 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aniLwNENxpoK-qK2@strlen.de \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.