From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linkmauve.fr (linkmauve.fr [82.65.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6F038F95E; Mon, 10 Aug 2026 11:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.65.109.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786360251; cv=none; b=GufBM6UwjcGPJoLzL+baKATH/TVfBMpV/WVpffTV+2YMaFvQXnVAnDAEMco94ngrIqjlzxEsaFRkDL4uUW2B+kXxxZ1pKTuF9uvz/mWIbyPsOACpFX21tv6SKWHkvn6xrW+e/wnQe9F5MMHBHN5jwXVh76uUcax0qnlVGlvY1u0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786360251; c=relaxed/simple; bh=+nd3weEl140R8chpOD8AjT/MtvS6Bl33g3C9BYFh9yY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gNmIZcJPbbn+22eNel2AoaH8QIgEeaLvrSt3wtoyoOG6cFFkVOkUDdM9HKCIYfkWsBuFDVbJfLDBnj1Jp25mqH8YQ+Qdk7SrdSrkxW37eFaDrjmJIFGeR/ELF5myd6xMYQ8WCv8MXqRF1Fke64zFySs5hT/HaFI9kXz/iysX2LU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr; spf=pass smtp.mailfrom=linkmauve.fr; arc=none smtp.client-ip=82.65.109.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linkmauve.fr Received: by linkmauve.fr (Postfix, from userid 1000) id 19C8370AFA9E; Mon, 10 Aug 2026 13:10:47 +0200 (CEST) Date: Mon, 10 Aug 2026 13:10:47 +0200 From: Link Mauve To: Andy Shevchenko Cc: Link Mauve , Srinivas Kandagatla , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Sven Peter , Janne Grunau , Neal Gompa , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , =?iso-8859-1?Q?Andr=E9?= Draszik , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Kalyani Akula , Michal Simek , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Johan Hovold , Ronald Claveau , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v4 0/3] nvmem: migrate to const void * in reg_write Message-ID: References: <20260726131724.15299-1-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr On Mon, Aug 10, 2026 at 10:27:33AM +0300, Andy Shevchenko wrote: > On Sun, Jul 26, 2026 at 03:17:18PM +0200, Link Mauve wrote: > > This callback used to take a mutable void * for no reason, which causes > > the compiler to be unaware that the val buffer should never be modified > > by the callback. > > > > This was found while drafting the nvmem-provider Rust abstraction. > > > > Thanks to the guidance of Andy Shevchenko, this now introduces a new > > callback and deprecates the existing one, with the goal of renaming the > > new one into the old one once no user remains in the kernel. > > LGTM now, FWIW, > Reviewed-by: Andy Shevchenko > > But I think you also need to provide a road map of finishing this job (the best > is to provide a continuation in some of yours public Git trees to point out). Also note that I sent a v5 a few days ago but you reviewed v4, although there are very few changes[1]. > > -- > With Best Regards, > Andy Shevchenko > > [1] https://lore.kernel.org/lkml/20260804135940.2378737-1-linkmauve@linkmauve.fr/T/ -- Link Mauve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85977C5AC82 for ; Mon, 10 Aug 2026 11:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r4mZitlyewccNkUJXYRIJll6gD+0SW4XmYdFXHSjjts=; b=XDuk0bFw3XoSMM fCKL7BO9GNNYSsXaqFItoCEeqvzO3Jw8fzAXHJioEruH1bsc/3lkGzq8CbDYXuwWNe2zt7HcjcRlP Z+vuYubrXrJXfadNGgP7g2EhSYpGexO2mi5DjpJdv3/m/8hytJZhhraH3+QHZbhf4Kun4qLANibk6 T4vI1XRc/5T7B71I/OyFE5bDPjGZf/8vjip4UuUA/zNHpMMCFwv0nKHv1o5EXvTUF2CoX/gcX3Zwz z8FX4mY2+4O+95LYIlHH17TWa4dDEYYMfDr3XFgox5DlOfI3FkfpVy4t4iv8X1ghqvNOCXzg0L2dg KBhqoDFVCWmzzeCRe7LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtNuB-0000000BZey-1USH; Mon, 10 Aug 2026 11:10:55 +0000 Received: from linkmauve.fr ([82.65.109.163]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtNu7-0000000BZeU-1OBW; Mon, 10 Aug 2026 11:10:53 +0000 Received: by linkmauve.fr (Postfix, from userid 1000) id 19C8370AFA9E; Mon, 10 Aug 2026 13:10:47 +0200 (CEST) Date: Mon, 10 Aug 2026 13:10:47 +0200 From: Link Mauve To: Andy Shevchenko Cc: Link Mauve , Srinivas Kandagatla , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Sven Peter , Janne Grunau , Neal Gompa , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , =?iso-8859-1?Q?Andr=E9?= Draszik , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Kalyani Akula , Michal Simek , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Johan Hovold , Ronald Claveau , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v4 0/3] nvmem: migrate to const void * in reg_write Message-ID: References: <20260726131724.15299-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260810_041051_545456_9EAE6F83 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Aug 10, 2026 at 10:27:33AM +0300, Andy Shevchenko wrote: > On Sun, Jul 26, 2026 at 03:17:18PM +0200, Link Mauve wrote: > > This callback used to take a mutable void * for no reason, which causes > > the compiler to be unaware that the val buffer should never be modified > > by the callback. > > > > This was found while drafting the nvmem-provider Rust abstraction. > > > > Thanks to the guidance of Andy Shevchenko, this now introduces a new > > callback and deprecates the existing one, with the goal of renaming the > > new one into the old one once no user remains in the kernel. > > LGTM now, FWIW, > Reviewed-by: Andy Shevchenko > > But I think you also need to provide a road map of finishing this job (the best > is to provide a continuation in some of yours public Git trees to point out). Also note that I sent a v5 a few days ago but you reviewed v4, although there are very few changes[1]. > > -- > With Best Regards, > Andy Shevchenko > > [1] https://lore.kernel.org/lkml/20260804135940.2378737-1-linkmauve@linkmauve.fr/T/ -- Link Mauve _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic