From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6EB32DF3EA for ; Mon, 10 Aug 2026 14:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.62.254.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786372381; cv=none; b=TV0bfChCu0iD5AwQXXOsP2ONsKZT4Z0EcNJdWfObmMn2PPyQaC/cy+ZM1hpVLyDBUHLOv9nAaKj6Ma44ZMjQPH6U9dq3KpySt/bcC6Mo5ewZkfhTyY9bqGenf6X1fbeE5zSAZZmQ3Wyid3SOrBVfHPK6EyI0FHUdfFQIFt3irGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786372381; c=relaxed/simple; bh=+d02wgPhIzYpJbPLl/Z2o1mbc+DvU14e/abE0aZ71v4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q/XhqXSzB6VPCUFC2NYEBe8kL9xpuQzGvT6iEpzSXIn1mEp8lzXfOVPgBMtuQMG8QmRZ4UCqMxPap2gRUJP/75xyI/qmKaPrEpwmkHVFwng0h3mvrfjGxkQIRpd3qflB3rI5nmD8agvPsmrZIewXrlDQe434EPeWm3STOEuwA9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com; spf=pass smtp.mailfrom=ilvokhin.com; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b=wK+jSYxx; arc=none smtp.client-ip=178.62.254.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b="wK+jSYxx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1786372372; bh=24Yvc/LSmJ1pR6Do+MPPFwwQrgIvWTHml801t6OskoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=wK+jSYxx2BsBA2tXXU3VAzeLaX+4vs1n/ShBWsZcfYYQ73PzyC3FRCpNrys57/Igb 51D00GAfC6MzLCZz10DixR1UWR8rfmPOzhB9AxNCONwyJzzKyiIWZPG2rIegg7o+Vr Bn+jUTzX3zSM91AwCRkzQqU++MK0/2Ls90TqQgE8= Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 50917E1B2D; Mon, 10 Aug 2026 14:32:52 +0000 (UTC) Date: Mon, 10 Aug 2026 14:32:48 +0000 From: Dmitry Ilvokhin To: Breno Leitao Cc: paulmck@kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Sebastian Andrzej Siewior , kernel-team@meta.com, Thomas Gleixner Subject: Re: [PATCH v2 1/3] locking/csd-lock: Pack csd_lock_wait_toolong() state into a struct Message-ID: References: <20260810-csd-stall-duration-v2-0-795083bf04a4@debian.org> <20260810-csd-stall-duration-v2-1-795083bf04a4@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260810-csd-stall-duration-v2-1-795083bf04a4@debian.org> On Mon, Aug 10, 2026 at 04:29:24AM -0700, Breno Leitao wrote: > csd_lock_wait_toolong() has some fields and they are being expanded now, > separate them into a structure, that can be easily digestible. > > This simplify the function aslo, given the fields were passed by > reference, and the ts0/ts1 names say nothing about what the two > timestamps hold. > > Pack them into struct csd_wait_state and name the timestamps for what > they store, ts_start and ts_report. The local ts2 becomes ts_now. > > Reporting a further timestamp, such as next patch, then costs a struct > member rather than another argument. > > No functional change. > > Suggested-by: Dmitry Ilvokhin > Signed-off-by: Breno Leitao Reviewed-by: Dmitry Ilvokhin