From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
Keith Busch <kbusch@kernel.org>,
syzbot+ac00e7bf7ac8c91af921@syzkaller.appspotmail.com
Subject: Re: [PATCH] loop, zloop: fix dma_alignment for large or unreported limits
Date: Mon, 10 Aug 2026 10:30:13 -0700 [thread overview]
Message-ID: <anoKpXNErXHEEVic@infradead.org> (raw)
In-Reply-To: <20260810164218.3721636-1-kbusch@meta.com>
On Mon, Aug 10, 2026 at 09:42:17AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> A file system sets STATX_DIOALIGN with zeroed alignments when the file
> can't be used for direct I/O. The zero underflowed to UINT_MAX and
> triggered a queue limits validation warning. Fall back to the block
> device's limits when dio_mem_align isn't reported.
>
> A file system with a block size larger than PAGE_SIZE may also report a
> memory alignment that can't be expressed as a queue limit. File systems
> fall back to buffered I/O for requests that don't meet their alignment,
> so cap the reported limit to the largest possible value.
In general having separate patches per driver would seem nicer than a
batched up one like this, but the changes do look good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-08-10 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 16:42 [PATCH] loop, zloop: fix dma_alignment for large or unreported limits Keith Busch
2026-08-10 17:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anoKpXNErXHEEVic@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=syzbot+ac00e7bf7ac8c91af921@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.