From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39A28C5B567 for ; Mon, 10 Aug 2026 17:36:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wtTuq-00011p-Su; Mon, 10 Aug 2026 13:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wtTun-000113-Dy for qemu-devel@nongnu.org; Mon, 10 Aug 2026 13:35:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wtTuh-0003OE-EM for qemu-devel@nongnu.org; Mon, 10 Aug 2026 13:35:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786383347; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cc2PQlzDh+avI1PRvEJJIfHuao41+BqBleXZRkT5iy8=; b=QXmm30lxVb2usWgGtNLj5Y8GS6AeTCFol99GVWNfTHruMv8BbUaj96Qkfr49T7EeeMONIv h+LeY7mgtYQKGHh4RgHBvHOGJ4jZwdT765Ba8YJhrO4ErrchOH7sHSjR9emwy02MJMv/0L TktW6Q7gom0a4BKG9S2uTGRQgFr6ax4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-e9IPaOI9O_C1k6qzuEtYRA-1; Mon, 10 Aug 2026 13:35:46 -0400 X-MC-Unique: e9IPaOI9O_C1k6qzuEtYRA-1 X-Mimecast-MFC-AGG-ID: e9IPaOI9O_C1k6qzuEtYRA_1786383345 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 57E3318001E2; Mon, 10 Aug 2026 17:35:45 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9C06B426; Mon, 10 Aug 2026 17:35:43 +0000 (UTC) Date: Mon, 10 Aug 2026 18:35:40 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Markus Armbruster Subject: Re: [PATCH v2 03/39] hmp: fix snapshot_blkdev argument type Message-ID: References: <20260626-qemu-no-hmp-v2-0-8af31bc54c61@redhat.com> <20260626-qemu-no-hmp-v2-3-8af31bc54c61@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260626-qemu-no-hmp-v2-3-8af31bc54c61@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.746, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jun 26, 2026 at 01:19:04AM +0400, Marc-André Lureau wrote: > The `snapshot-file` argument for `snapshot_blkdev` is mandatory. Correct > the `args_type` definition to reflect this. > > Fixes: 6106e2492fe ("qapi: Convert blockdev_snapshot_sync") This seems to have been an intentional design choice, rather than a bug. In hmp_snapshot_blkdev there is code with a comment: if (!filename) { /* In the future, if 'snapshot-file' is not specified, the snapshot will be taken internally. Today it's actually required. */ error_set(&errp, QERR_MISSING_PARAMETER, "snapshot-file"); hmp_handle_error(mon, &errp); return; } 15 years on though, the future enhancement still hasn't arrived. IMHO the original design choice was a mistake. We should have been it mandatory at the start, since we had freedom to relax that later. So I'm in favour of your change, but it should update hmp_snapshot_blkdev to remove what will now be dead code checking for "!filename". > Signed-off-by: Marc-André Lureau > --- > hmp-commands.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 2b658bbbf28..1e286b7c89d 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1168,7 +1168,7 @@ ERST > > { > .name = "snapshot_blkdev", > - .args_type = "reuse:-n,device:B,snapshot-file:s?,format:s?", > + .args_type = "reuse:-n,device:B,snapshot-file:s,format:s?", > .params = "[-n] device [new-image-file] [format]", > .help = "initiates a live snapshot\n\t\t\t" > "of device. If a new image file is specified, the\n\t\t\t" > > -- > 2.54.0 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|