Re: [PATCH v2 09/39] hmp: correct the nmi documentation

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Jun 26, 2026 at 01:19:10AM +0400, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hmp-commands.hx | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 1e286b7c89d..129052963c7 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -868,8 +868,9 @@ ERST
>          .cmd        = hmp_nmi,
>      },
>  SRST
> -``nmi`` *cpu*
> -  Inject an NMI on the default CPU (x86/s390) or all CPUs (ppc64).
> +``nmi``
> +  Inject an NMI on the associated monitor vCPU (``cpu`` command, on s390x) or
> +  all vCPUs (on other architectures).

For consistency with QMP shouldn't this say

   Inject an NMI on the associated monitor vCPU (``cpu`` command, on s390x) or
   all vCPUs (x86, hppa, ppc64), or does nothing on other architectures

?



With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|